Skip to content

Commit

Permalink
Redistribute iOS TESTOWNERS (flutter#163653)
Browse files Browse the repository at this point in the history
Redistributed TESTOWNERS to take @jmagman out of the mix and add
@vashworth and @loic-sharma.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
  • Loading branch information
vashworth authored Feb 20, 2025
1 parent 98fe867 commit 7251a06
Showing 1 changed file with 23 additions and 23 deletions.
46 changes: 23 additions & 23 deletions TESTOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -167,38 +167,38 @@
## Mac iOS DeviceLab tests
/dev/devicelab/bin/tasks/animated_complex_opacity_perf_ios__e2e_summary.dart @hellohuanlin @flutter/engine
/dev/devicelab/bin/tasks/animation_with_microtasks_perf_ios__timeline_summary.dart @jtmcdole @flutter/engine
/dev/devicelab/bin/tasks/backdrop_filter_perf_ios__timeline_summary.dart @hellohuanlin @flutter/engine
/dev/devicelab/bin/tasks/basic_material_app_ios__compile.dart @jmagman @flutter/tool
/dev/devicelab/bin/tasks/channels_integration_test_ios.dart @jmagman @flutter/engine
/dev/devicelab/bin/tasks/backdrop_filter_perf_ios__timeline_summary.dart @louisehsu @flutter/engine
/dev/devicelab/bin/tasks/basic_material_app_ios__compile.dart @vashworth @flutter/tool
/dev/devicelab/bin/tasks/channels_integration_test_ios.dart @loic-sharma @flutter/engine
/dev/devicelab/bin/tasks/codegen_integration_mac.dart @bkonyi @flutter/tool
/dev/devicelab/bin/tasks/color_filter_and_fade_perf_ios__e2e_summary.dart @hellohuanlin @flutter/engine
/dev/devicelab/bin/tasks/complex_layout_ios__start_up.dart @louisehsu @flutter/engine
/dev/devicelab/bin/tasks/color_filter_and_fade_perf_ios__e2e_summary.dart @louisehsu @flutter/engine
/dev/devicelab/bin/tasks/complex_layout_ios__start_up.dart @vashworth @flutter/engine
/dev/devicelab/bin/tasks/complex_layout_scroll_perf_bad_ios__timeline_summary.dart @jonahwilliams @flutter/engine
/dev/devicelab/bin/tasks/complex_layout_scroll_perf_ios__timeline_summary.dart @hellohuanlin @flutter/engine
/dev/devicelab/bin/tasks/complex_layout_scroll_perf_ios__timeline_summary.dart @louisehsu @flutter/engine
/dev/devicelab/bin/tasks/cubic_bezier_perf_ios_sksl_warmup__timeline_summary.dart @jtmcdole @flutter/engine
/dev/devicelab/bin/tasks/external_textures_integration_test_ios.dart @jtmcdole @flutter/engine
/dev/devicelab/bin/tasks/flavors_test_ios.dart @jmagman @flutter/tool
/dev/devicelab/bin/tasks/flavors_test_ios.dart @vashworth @flutter/tool
/dev/devicelab/bin/tasks/flutter_gallery__transition_perf_e2e_ios.dart @jtmcdole @flutter/engine
/dev/devicelab/bin/tasks/flutter_gallery_ios__compile.dart @jmagman @flutter/engine
/dev/devicelab/bin/tasks/flutter_gallery_ios__start_up.dart @louisehsu @flutter/engine
/dev/devicelab/bin/tasks/flutter_gallery_ios__compile.dart @vashworth @flutter/engine
/dev/devicelab/bin/tasks/flutter_gallery_ios__start_up.dart @vashworth @flutter/engine
/dev/devicelab/bin/tasks/flutter_gallery_ios_sksl_warmup__transition_perf.dart @jtmcdole @flutter/engine
/dev/devicelab/bin/tasks/flutter_view_ios__start_up.dart @jtmcdole @flutter/engine
/dev/devicelab/bin/tasks/fullscreen_textfield_perf_ios__e2e_summary.dart @louisehsu @flutter/engine
/dev/devicelab/bin/tasks/hello_world_ios__compile.dart @jmagman @flutter/engine
/dev/devicelab/bin/tasks/hello_world_ios__compile.dart @vashworth @flutter/engine
/dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios__benchmark.dart @louisehsu @flutter/tool
/dev/devicelab/bin/tasks/imitation_game_flutter__compile.dart @louisehsu @flutter/tool
/dev/devicelab/bin/tasks/imitation_game_swiftui__compile.dart @louisehsu @flutter/tool
# TODO(vashworth): Remove once https://github.com/flutter/flutter/issues/142305 is fixed.
/dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios__benchmark_no_dds.dart @louisehsu @flutter/tool
/dev/devicelab/bin/tasks/imagefiltered_transform_animation_perf_ios__timeline_summary.dart @hellohuanlin @flutter/engine
/dev/devicelab/bin/tasks/integration_test_test_ios.dart @jmagman @flutter/engine
/dev/devicelab/bin/tasks/integration_ui_ios_driver.dart @louisehsu @flutter/tool
/dev/devicelab/bin/tasks/imagefiltered_transform_animation_perf_ios__timeline_summary.dart @louisehsu @flutter/engine
/dev/devicelab/bin/tasks/integration_test_test_ios.dart @loic-sharma @flutter/engine
/dev/devicelab/bin/tasks/integration_ui_ios_driver.dart @loic-sharma @flutter/tool
/dev/devicelab/bin/tasks/integration_ui_ios_frame_number.dart @jtmcdole @flutter/engine
/dev/devicelab/bin/tasks/integration_ui_ios_keyboard_resize.dart @louisehsu @flutter/engine
/dev/devicelab/bin/tasks/integration_ui_ios_screenshot.dart @louisehsu @flutter/tool
/dev/devicelab/bin/tasks/integration_ui_ios_textfield.dart @louisehsu @flutter/tool
/dev/devicelab/bin/tasks/ios_app_with_extensions_test.dart @jmagman @flutter/tool
/dev/devicelab/bin/tasks/ios_defines_test.dart @jmagman @flutter/tool
/dev/devicelab/bin/tasks/integration_ui_ios_keyboard_resize.dart @loic-sharma @flutter/engine
/dev/devicelab/bin/tasks/integration_ui_ios_screenshot.dart @loic-sharma @flutter/tool
/dev/devicelab/bin/tasks/integration_ui_ios_textfield.dart @loic-sharma @flutter/tool
/dev/devicelab/bin/tasks/ios_app_with_extensions_test.dart @vashworth @flutter/tool
/dev/devicelab/bin/tasks/ios_defines_test.dart @louisehsu @flutter/tool
/dev/devicelab/bin/tasks/ios_picture_cache_complexity_scoring_perf__timeline_summary.dart @flar @flutter/engine
/dev/devicelab/bin/tasks/ios_platform_view_tests.dart @stuartmorgan @flutter/plugin
/dev/devicelab/bin/tasks/large_image_changer_perf_ios.dart @jtmcdole @flutter/engine
Expand All @@ -218,7 +218,7 @@
/dev/devicelab/bin/tasks/platform_views_scroll_perf_ios__timeline_summary.dart @hellohuanlin @flutter/engine
/dev/devicelab/bin/tasks/platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary.dart @jonahwilliams @flutter/engine
/dev/devicelab/bin/tasks/post_backdrop_filter_perf_ios__timeline_summary.dart @hellohuanlin @flutter/engine
/dev/devicelab/bin/tasks/route_test_ios.dart @jmagman @flutter/tool
/dev/devicelab/bin/tasks/route_test_ios.dart @vashworth @flutter/tool
/dev/devicelab/bin/tasks/simple_animation_perf_ios.dart @hellohuanlin @flutter/engine
/dev/devicelab/bin/tasks/tiles_scroll_perf_ios__timeline_summary.dart @hellohuanlin @flutter/engine
/dev/devicelab/bin/tasks/very_long_picture_scrolling_perf_ios__e2e_summary.dart @flar @flutter/engine
Expand All @@ -235,7 +235,7 @@
/dev/devicelab/bin/tasks/android_release_builds_exclude_dev_dependencies_test.dart @camsim99 @flutter/android
/dev/devicelab/bin/tasks/basic_material_app_macos__compile.dart @cbracken @flutter/desktop
/dev/devicelab/bin/tasks/build_aar_module_test.dart @bkonyi @flutter/tool
/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart @jmagman @flutter/tool
/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart @vashworth @flutter/tool
/dev/devicelab/bin/tasks/channels_integration_test_macos.dart @gaaclarke @flutter/desktop
/dev/devicelab/bin/tasks/complex_layout_macos__compile.dart @cbracken @flutter/desktop
/dev/devicelab/bin/tasks/complex_layout_macos__start_up.dart @cbracken @flutter/desktop
Expand All @@ -244,7 +244,7 @@
/dev/devicelab/bin/tasks/complex_layout_win_desktop__start_up.dart @yaakovschectman @flutter/desktop
/dev/devicelab/bin/tasks/dart_plugin_registry_test.dart @stuartmorgan @flutter/plugin
/dev/devicelab/bin/tasks/entrypoint_dart_registrant.dart @aaclarke @flutter/plugin
/dev/devicelab/bin/tasks/flavors_test_macos.dart @cbracken @flutter/desktop
/dev/devicelab/bin/tasks/flavors_test_macos.dart @vashworth @flutter/desktop
/dev/devicelab/bin/tasks/flutter_gallery_macos__compile.dart @cbracken @flutter/desktop
/dev/devicelab/bin/tasks/flutter_gallery_macos__start_up.dart @cbracken @flutter/desktop
/dev/devicelab/bin/tasks/flutter_gallery_win_desktop__compile.dart @yaakovschectman @flutter/desktop
Expand All @@ -270,7 +270,7 @@
/dev/devicelab/bin/tasks/module_host_with_custom_build_test.dart @bkonyi @flutter/tool
/dev/devicelab/bin/tasks/build_android_host_app_with_module_aar.dart @bkonyi @flutter/tool
/dev/devicelab/bin/tasks/build_android_host_app_with_module_source.dart @gmackall @flutter/android
/dev/devicelab/bin/tasks/module_test_ios.dart @jmagman @flutter/tool
/dev/devicelab/bin/tasks/module_test_ios.dart @vashworth @flutter/tool
/dev/devicelab/bin/tasks/native_assets_ios_simulator.dart @dcharkes @flutter/ios
/dev/devicelab/bin/tasks/native_ui_tests_macos.dart @cbracken @flutter/desktop
/dev/devicelab/bin/tasks/platform_channel_sample_test_macos.dart @cbracken @flutter/desktop
Expand All @@ -281,7 +281,7 @@
/dev/devicelab/bin/tasks/plugin_test.dart @stuartmorgan @flutter/plugin
/dev/devicelab/bin/tasks/plugin_test_ios.dart @stuartmorgan @flutter/ios
/dev/devicelab/bin/tasks/plugin_test_linux.dart @stuartmorgan @flutter/desktop
/dev/devicelab/bin/tasks/plugin_test_macos.dart @cbracken @flutter/desktop
/dev/devicelab/bin/tasks/plugin_test_macos.dart @vashworth @flutter/desktop
/dev/devicelab/bin/tasks/plugin_test_windows.dart @loic-sharma @flutter/desktop
/dev/devicelab/bin/tasks/run_debug_test_android.dart @bkonyi @flutter/tool
/dev/devicelab/bin/tasks/run_debug_test_android.dart @bkonyi @flutter/tool
Expand Down

0 comments on commit 7251a06

Please sign in to comment.