-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stopping run when messages remain #619
base: master
Are you sure you want to change the base?
fix: stopping run when messages remain #619
Conversation
the fact that this hasn't bee pushed is sad |
I tested this extensively, and sadly there seems to be the side effect that sometimes Discord API's reported total message count appears to be wrong and then this pull request version gets stuck forever looping on empty pages when it wrongly assumes a handful of messages are left. I would propose to adjust this pull request such that if some threshold of empty pages was encountered in a row, maybe 10+, then it should assume perhaps everything was deleted after all. |
What @ell1e said is absolutely correct. Seconded, if that's a thing I can do. |
how do i use ur version of the code |
Still not working for me at least, had to edit the script , place this before the "Ended at" string, it will press the delete button again for u `
also remove the confirm() function call |
- Resolved ESLint issues and addressed invalid header warnings (victornpb#663). - Implemented autofill for thread channel IDs and restricted message deletion to the corresponding thread (victornpb#610). - Clarified that omitting a time will disable the date filter functionality (victornpb#643). - Added a filter to exclude messages containing files or attachments (victornpb#642). - Fixed various autofill issues (victornpb#631). - Stopped execution when there are remaining messages (victornpb#619). - Addressed API errors related to the Wipe Archive Feature (50024 - 50021) (victornpb#603). - Implemented a workaround for slow search index refreshing (victornpb#584).
Should address #598, #540, #536 - tested by hand modifying script
Let me know if there's anything that needs to change!
Usable gist: https://gist.github.com/gm112/d2387494497c2086e4bd4862bf8e0f89