-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added logic to skip messages belonging to archived/locked threads #393
base: master
Are you sure you want to change the base?
Conversation
Not a proper developer, just wanted to try this out as it has been annoying me too. This does seem to work when there are messages in archived threads, but doesn't when there are none in the first search results. Started at 9/17/2022, 9:45:40 PM |
@tbernaerd hey , i din't handle the display message , but it should still continue to work nevertheless even if you get the wrong message in the output i guess , please confirm if it still fails to work as you continue. |
Hi, that's fair just wanted to report my findings. I'm trying this on a server for my own messages without a channel filter. The normal version of the script gets into an archived thread delete fail loop fairly quickly, therefore never reaching other messages to delete. Your version seems to work when I do use the channel filter, but not when I don't. The popup with the number of messages never shows and it appears stuck. |
I hope this can get merged now as the use of threading is very much common place in a lot of servers. |
Hey, just implemented my own fix just atop the newer 5.1.1 version: |
Added the logic to skip messages that belong to threads.
Api calls will no longer be made if the message belongs to an archived/locked thread.
Note: I formatted the code using prettier.
Refer Issue : #242