-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry deletion of message if deletion fails #225
Open
BepisGithub
wants to merge
15
commits into
victornpb:master
Choose a base branch
from
BepisGithub:retry-delete-on-failure
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Retry deletion of message if deletion fails #225
BepisGithub
wants to merge
15
commits into
victornpb:master
from
BepisGithub:retry-delete-on-failure
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes #132 |
victornpb
added
the
PR missing src files (can't merge)
Doesn't contain changes to src files. (Please read CONTRIBUTING)
label
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR missing src files (can't merge)
Doesn't contain changes to src files. (Please read CONTRIBUTING)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug being solved:
Prior to these changes, if deleting a message threw an error, the script would stop deleting any more messages. This was inconvenient because on slower connections a deletion may time out from time to time and throw an error, which would cause the script to stop.
Changes:
Implementation:
I wrapped the code to delete a message in a do while block and used two variables to ensure the block would get run again if there was an error after trying to delete the message (for a maximum of 5 reattempts). If there was no error, the script would move on to the next message.
To ensure the script would continue working if there was an error when deleting the message, I nested the "if (!resp.ok)" statement within an if statement that wouldn't evaluate to true if resp was undefined (this fixed the script stopping if deleting the message threw an error).
This change is