Remove support for non-safe REST methods #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
force-pushed
the
disallow_unsafe_rest_interfaces
branch
3 times, most recently
from
3d30a62 to
12059a4
Compare
Geod24
reviewed
Feb 7, 2024
| @@ -48,7 +48,8 @@ class LocalThreadAPI : ThreadAPI { | |||
|
|
|||
| string[] get() | |||
| { | |||
| return m_data.threads.keys; | |||
| // NOTE: .keys is not @safe on older compiler versions | |||
There was a problem hiding this comment.
Do you know from what version it is ?
There was a problem hiding this comment.
I tested it now on run.dlang.io and it works starting with 2.098.1.
There was a problem hiding this comment.
Rebased and added a static if(__VERSION__).
s-ludwig
force-pushed
the
disallow_unsafe_rest_interfaces
branch
from
ac5973e to
3f8ee3e
Compare
s-ludwig
force-pushed
the
disallow_unsafe_rest_interfaces
branch
from
80ea964 to
cc7b7a7
Compare
l-kramer
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes up on #2748 and uses a clear error message instead of letting the compiler output indirect errors.
Closes #2748.