-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forward compatibility for changing HTTPServerRequest from class to struct #2534
Conversation
@s-ludwig it seems to me that having |
The reasoning for their separation still stands - the core repositories are more or less stable currently and it would be a huge annoyance to bump their major version because of a breaking change in vibe:web or vibe:mongodb. Having them separate is a huge relief w.r.t. advancing their individual APIs. Friction like the one here is also annoying, but really not that much compared to the alternative. |
7a14e86
to
cf645e9
Compare
I don't follow. What prevents doing what you're already doing if you have the packages inside the same repo vs in multiple repos? My idea is not to release all the packages in lock step (like we do with |
The registry doesn't support multiple independent packages inside the same repository, and can't without considerable effort, so that won't AFAICS. |
Oh, I wasn't aware of this limitation... it sounds like a deal breaker for monorepo-style development :/ Oh well. P.S. I will open an issue for discussion on the dub repo, to not pollute the discussion of this PR further. |
It would indeed be nice to support that, but the question is how - by extending the version tag mechanism (e.g. "vibe-d-v1.0.0" and "vibe-http-v1.0.0" instead of just "v1.0.0"), or by storing the version inside dub.sdl and going through the complete git history to determine the corresponding commits? But yeah, let's move that to a dedicated ticket. |
32fd996
to
1c93047
Compare
2907164
to
8eebfce
Compare
After the big restructuring, where vibe-http for now is simply the previous state of vibe-d:http master, the only relevant changes left in this branch are a few changes where |
Makes the code forward-compatible with a switch from class to struct for HTTPServerRequest.
No description provided.