Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to compile on FreeBSD #203

Closed
wants to merge 1 commit into from
Closed

Minor fix to compile on FreeBSD #203

wants to merge 1 commit into from

Conversation

stackyjoe
Copy link

See issue #202

@Geod24
Copy link
Contributor

Geod24 commented Nov 23, 2021

Is this ready ?

@herrhotzenplotz
Copy link

Just chiming in here, while being confronted with exactly this issue:

the patch perfectly solves the compilation failure on the following (and other test systems):

$ dmd --version
DMD64 D Compiler v2.098.0-40-g54fa6ee34
Copyright (C) 1999-2021 by The D Language Foundation, All Rights Reserved written by Walter Bright
$ uname -omr
FreeBSD 13.0-RELEASE-p6 amd64
$ 

Changes are not causing any trouble at runtime and things are running stable for me.
I'd be glad if this gets merged as quickly as possible.

@s-ludwig
Copy link
Member

The only question I'd have is whether this is changing anything on macOS, because that is also changed to use lseek - keeping the old call in another version (OSX) block would avoid that potential issue.

s-ludwig added a commit that referenced this pull request May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants