Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XDG base directory spec #93

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Use XDG base directory spec #93

merged 6 commits into from
Dec 4, 2024

Conversation

KaiWaldrant
Copy link
Contributor

@KaiWaldrant KaiWaldrant commented Jul 5, 2024

change viash install directory

Close #92

@KaiWaldrant KaiWaldrant requested a review from rcannood July 5, 2024 19:24
Copy link

github-actions bot commented Jul 5, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-04 09:22 UTC

installation/index.qmd Outdated Show resolved Hide resolved
installation/index.qmd Outdated Show resolved Hide resolved
@Grifs
Copy link
Contributor

Grifs commented Jul 9, 2024

Giving users instructions to mess with their /usr/... folders is risky in my opinion and in general considered bad practice to do so (the fiddling, not per se the instructing).

  • This requires the user to have root access
  • This folder is generally managed by package managers, and while I don't think we'll likely override anything, we may still do something odd? [this thought might be wrong/outdated]
  • This is very distro dependant, ie. the expected folder might not be /usr/local/bin [this thought might be wrong/outdated]
  • The more correct way would be to user /opt, but maybe there is a distro that also doesn't follow that topology? [I guess this is more for bigger packages, not single executables]

tl;dr it's not my prefered way, but it's a personal opinion. However, the user does need to have root access.


```bash
curl -fsSL dl.viash.io | bash; mv viash $HOME/bin
wget -qO- dl.viash.io | bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't the reason the original command used curl that macOS doesn't necessarily have wget but was sure to have curl?

@rcannood
Copy link
Member

Giving users instructions to mess with their /usr/... folders is risky in my opinion and in general considered bad practice to do so (the fiddling, not per se the instructing).

I agree, though I suggested installing it in /usr/local/bin because $HOME/bin and $HOME/.local/bin are not on the PATH out of the box. Then again, we could just have separate installation instructions for Mac OS X.

@rcannood
Copy link
Member

Oh, I know, I know!

set +e; IFS=":"; for dir in $PATH; do cp viash $dir; done

?

@Grifs
Copy link
Contributor

Grifs commented Jul 18, 2024

I merged main in the PR, with all 3 options moving viash to /usr/local/bin, but with using curl for macOS. However I tweaked the wording ever so slightly.

@tverbeiren tverbeiren requested review from rcannood and Grifs December 3, 2024 16:06
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@rcannood rcannood merged commit b186518 into main Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use XDG base directory to install viash
4 participants