Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping release version #30

Merged
merged 1 commit into from
May 14, 2024
Merged

Bumping release version #30

merged 1 commit into from
May 14, 2024

Conversation

cheukt
Copy link
Member

@cheukt cheukt commented May 14, 2024

No description provided.

@cheukt cheukt requested a review from a team as a code owner May 14, 2024 15:25
@cheukt cheukt requested review from njooma and purplenicole730 and removed request for a team May 14, 2024 15:25
stuqdog
stuqdog reviewed May 14, 2024
View reviewed changes
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, we definitely want to get rid of the -SNAPSHOT suffix? I don't fully understand it but in my head it roughly analogizes to a beta indicator. @njooma in case you have thoughts?

@njooma
Copy link
Member

njooma commented May 14, 2024

Ya snapshot just means beta which we aren't doing

@cheukt cheukt merged commit 5155129 into main May 14, 2024
2 checks passed
@cheukt cheukt deleted the bumping-version branch May 14, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuqdog stuqdog stuqdog approved these changes

@njooma njooma njooma approved these changes

@purplenicole730 purplenicole730 Awaiting requested review from purplenicole730 purplenicole730 is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheukt @njooma @stuqdog