Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-9622: Add Discover Service and GetModelsFromModules to Flutter #321

Merged
merged 12 commits into from
Jan 22, 2025

Conversation

martha-johnston
Copy link
Contributor

No description provided.

@martha-johnston
Copy link
Contributor Author

I think these won't pass until api is updated, which will happen with this PR

@martha-johnston martha-johnston marked this pull request as ready for review January 10, 2025 21:49
@martha-johnston martha-johnston requested a review from a team as a code owner January 10, 2025 21:49
@martha-johnston
Copy link
Contributor Author

I'm unsure why some of these tests aren't passing, specifically the failures related to vision, because I didn't make any vision changes.

Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the Flutter SDK so you might want to wait on Naveed's approval as well, but lgtm at a first glance!

@martha-johnston
Copy link
Contributor Author

@njooma let me know if you have any suggestions on why the test I wrote might be failing. the error that I'm most confused by is Error: Type 'DiscoveryClient' not found because I believe I am importing DiscoveryClient correctly in the test, but I could be wrong, I'm not sure.

@njooma
Copy link
Member

njooma commented Jan 22, 2025

you were missing an export. took the liberty of adding it for you

@martha-johnston
Copy link
Contributor Author

you were missing an export. took the liberty of adding it for you

thank you!

@martha-johnston martha-johnston merged commit 5d442c7 into viamrobotics:main Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants