DOCS-2400: Add snippets for resource base methods #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessamyT
commented
Jun 13, 2024
Comment on lines
+29
to
+33
| /// | ||
| /// ``` | ||
| /// // Example, creating a Sensor from a resource named "mySensor": | ||
| /// var mySensor = Sensor.fromResourceName('mySensor'); | ||
| /// ``` |
There was a problem hiding this comment.
Suggested change
| /// | |
| /// ``` | |
| /// // Example, creating a Sensor from a resource named "mySensor": | |
| /// var mySensor = Sensor.fromResourceName('mySensor'); | |
| /// ``` |
Should these actually not be here since they're not part of the API?
There was a problem hiding this comment.
There may be considerations I'm not thinking of but it seems harmless and more thorough to include these.
JessamyT
commented
Jun 13, 2024
Comment on lines
+40
to
+44
| /// | ||
| /// ``` | ||
| /// // Example, getting the ResourceName of a sensor named "my_sensor": | ||
| /// var resourceName = Sensor.getResourceName('my_sensor'); | ||
| /// ``` |
There was a problem hiding this comment.
Suggested change
| /// | |
| /// ``` | |
| /// // Example, getting the ResourceName of a sensor named "my_sensor": | |
| /// var resourceName = Sensor.getResourceName('my_sensor'); | |
| /// ``` |
stuqdog
approved these changes
Jun 13, 2024
Comment on lines
+29
to
+33
| /// | ||
| /// ``` | ||
| /// // Example, creating a Sensor from a resource named "mySensor": | ||
| /// var mySensor = Sensor.fromResourceName('mySensor'); | ||
| /// ``` |
There was a problem hiding this comment.
There may be considerations I'm not thinking of but it seems harmless and more thorough to include these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.