Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-9658: Use atomic counter for module port allocation. #4684

Merged
merged 1 commit into from
Jan 7, 2025
Merged

RSDK-9658: Use atomic counter for module port allocation. #4684

merged 1 commit into from
Jan 7, 2025

Conversation

dgottlieb
Copy link
Member

Missed this in the review -- the [Mod]Manager.add() function can be called concurrently. Causing a data race on the reads/adds of the port counter.

@dgottlieb dgottlieb requested a review from abe-winter January 7, 2025 15:37
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Jan 7, 2025
abe-winter
abe-winter approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@abe-winter abe-winter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dgottlieb dgottlieb merged commit 4df774c into viamrobotics:main Jan 7, 2025
16 checks passed
@dgottlieb dgottlieb deleted the RSDK-9658 branch January 7, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abe-winter abe-winter abe-winter approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgottlieb @abe-winter @viambot