New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-8551 - module generation in CI #4315

Closed

stuqdog wants to merge 24 commits into viamrobotics:main from stuqdog:module-gen-in-cli

Member

stuqdog commented Aug 23, 2024 •

edited

Loading

Module boilerplate generation in CLI. Confirmed builds successfully in CI.

Note to reviewers that this is still a bit of a WIP. In particular, fixing CI test failures is still ongoing, and the cookiecutter templates will likely be updated before released based on viamrobotics/viam-python-sdk#716.

Once this is merged we'll need to release viamrobotics/homebrew-brews#47 as well.

Edit: putting back into draft mode while some of this logic gets moved to a separate repo.


          init commit, need to test

65aadc5

viambot added the safe to test label


          add fake test

aac0964

viambot added safe to test and removed safe to test labels


          run fake test

5fc7624

viambot added safe to test and removed safe to test labels


          sudo

46c483d

viambot added safe to test and removed safe to test labels


          remove poetry

a1fce28

viambot added safe to test and removed safe to test labels


          fix -ci suffix, make sure makefile is read correctly

edea326

viambot added safe to test and removed safe to test labels


          what is the event name

72a8ed4

viambot added safe to test and removed safe to test labels


          run on PR for testing

90d0556

viambot added safe to test and removed safe to test labels


          remove all reference to uploading or release versions, just testing h…

aefbfb7

…ere\!

viambot added safe to test and removed safe to test labels


          make sure call to module generate works

21dbc25

viambot added safe to test and removed safe to test labels


          tree

f290e80

viambot added safe to test and removed safe to test labels

stuqdog marked this pull request as ready for review

August 23, 2024 18:35

stuqdog mentioned this pull request

RSDK-8551 - update cli dependencies viamrobotics/homebrew-brews#47

Closed


          test making python __main__ a dependency of go build

23ab5c7

viambot added safe to test and removed safe to test labels

stuqdog added 2 commits

August 26, 2024 14:56


          dummy file to remove python dependency from go build

6c39cd1


          actually add dummy file

d885bf5

viambot added safe to test and removed safe to test labels


          forgot to add build.sh whoops

ad547d3

viambot added safe to test and removed safe to test labels


          linter fixes

2fbdb62

viambot added safe to test and removed safe to test labels

stuqdog marked this pull request as draft

August 27, 2024 15:48


          download generator from external source

2830a42

viambot added safe to test and removed safe to test labels


          remove python dependency

viambot added safe to test and removed safe to test labels


          fix makefile, remove test code

5d7b333

viambot added safe to test and removed safe to test labels

Member Author

stuqdog commented Aug 29, 2024

Note to @viamrobotics/sdk-netcode: this should be mostly ready for release. The things that are still necessary are:

getting https://github.com/viamrobotics/module-template-generator/pull/1 merged and creating an actual release.
making the module-template-generator repo public once we have a release, so that curl can access and download builds successfully. (SDK-netcode are owners of the repo so anyone should be able to do this)

Member

njooma commented Oct 8, 2024

@stuqdog I believe we can close this now that we're not using pyinstaller anymore?

stuqdog closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels