Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-4414: flaky gpiostepper test fix #2821

Merged
merged 2 commits into from
Aug 23, 2023
Merged

RSDK-4414: flaky gpiostepper test fix #2821

merged 2 commits into from
Aug 23, 2023

Conversation

stevebriskin
Copy link
Member

Very hard to actually repro this, only failed once in CI and I couldn't repro locally. Theory is that IsPowered() returns true before doCycle() is ever called, so it's possible for IsPowered == true while position is still 0.

@stevebriskin stevebriskin requested a review from randhid August 23, 2023 16:18
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Aug 23, 2023
randhid
randhid approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@randhid randhid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this fixes it.

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Aug 23, 2023
@github-actions
Copy link
Contributor

Code Coverage

Code Coverage
Package Line Rate Delta Health
go.viam.com/rdk/cli 4% 0.00% ❌
go.viam.com/rdk/components/arm 59% 0.00% ➖
go.viam.com/rdk/components/arm/fake 27% 0.00% ❌
go.viam.com/rdk/components/arm/universalrobots 42% -0.48% ❌
go.viam.com/rdk/components/arm/wrapper 19% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 22% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 6% 0.00% ❌
go.viam.com/rdk/components/audioinput 43% 0.00% ❌
go.viam.com/rdk/components/base 60% 0.00% ➖
go.viam.com/rdk/components/base/agilex 60% 0.00% ➖
go.viam.com/rdk/components/base/kinematicbase 43% 0.00% ❌
go.viam.com/rdk/components/base/sensorbase 68% 0.00% ➖
go.viam.com/rdk/components/base/wheeled 89% 0.00% ✅
go.viam.com/rdk/components/board 60% 0.00% ➖
go.viam.com/rdk/components/board/customlinux 50% 0.00% ➖
go.viam.com/rdk/components/board/fake 38% 0.00% ❌
go.viam.com/rdk/components/board/genericlinux 8% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi/impl 11% 0.00% ❌
go.viam.com/rdk/components/camera 57% 0.00% ➖
go.viam.com/rdk/components/camera/align 58% 0.00% ➖
go.viam.com/rdk/components/camera/fake 74% 0.00% ✅
go.viam.com/rdk/components/camera/ffmpeg 82% 0.00% ✅
go.viam.com/rdk/components/camera/replaypcd 90% 0.00% ✅
go.viam.com/rdk/components/camera/rtsp 52% 0.00% ➖
go.viam.com/rdk/components/camera/transformpipeline 73% 0.00% ✅
go.viam.com/rdk/components/camera/ultrasonic 61% 0.00% ➖
go.viam.com/rdk/components/camera/videosource 39% 0.00% ❌
go.viam.com/rdk/components/encoder 57% 0.00% ➖
go.viam.com/rdk/components/encoder/ams 63% 0.00% ➖
go.viam.com/rdk/components/encoder/fake 83% 0.00% ✅
go.viam.com/rdk/components/encoder/incremental 80% 0.00% ✅
go.viam.com/rdk/components/encoder/single 86% 0.00% ✅
go.viam.com/rdk/components/gantry 60% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 82% 0.00% ✅
go.viam.com/rdk/components/gantry/singleaxis 81% 0.00% ✅
go.viam.com/rdk/components/generic 79% 0.00% ✅
go.viam.com/rdk/components/gripper 56% 0.00% ➖
go.viam.com/rdk/components/input 88% 0.00% ✅
go.viam.com/rdk/components/input/fake 94% +1.49% ✅
go.viam.com/rdk/components/input/gpio 85% 0.00% ✅
go.viam.com/rdk/components/motor 71% 0.00% ✅
go.viam.com/rdk/components/motor/dimensionengineering 67% 0.00% ➖
go.viam.com/rdk/components/motor/dmc4000 70% 0.00% ➖
go.viam.com/rdk/components/motor/fake 55% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 73% 0.00% ✅
go.viam.com/rdk/components/motor/gpiostepper 66% 0.00% ➖
go.viam.com/rdk/components/motor/tmcstepper 53% 0.00% ➖
go.viam.com/rdk/components/motor/ulnstepper 53% 0.00% ➖
go.viam.com/rdk/components/movementsensor 74% 0.00% ✅
go.viam.com/rdk/components/movementsensor/adxl345 75% 0.00% ✅
go.viam.com/rdk/components/movementsensor/gpsnmea 55% 0.00% ➖
go.viam.com/rdk/components/movementsensor/gpsrtkpmtk 21% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsrtkserial 28% 0.00% ❌
go.viam.com/rdk/components/movementsensor/merged 91% 0.00% ✅
go.viam.com/rdk/components/movementsensor/mpu6050 84% 0.00% ✅
go.viam.com/rdk/components/movementsensor/replay 93% 0.00% ✅
go.viam.com/rdk/components/movementsensor/rtkutils 24% 0.00% ❌
go.viam.com/rdk/components/movementsensor/wheeledodometry 76% 0.00% ✅
go.viam.com/rdk/components/posetracker 71% 0.00% ✅
go.viam.com/rdk/components/powersensor 49% 0.00% ❌
go.viam.com/rdk/components/sensor 51% 0.00% ➖
go.viam.com/rdk/components/sensor/ultrasonic 38% 0.00% ❌
go.viam.com/rdk/components/servo 62% 0.00% ➖
go.viam.com/rdk/components/servo/gpio 72% 0.00% ✅
go.viam.com/rdk/config 80% 0.00% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 73% 0.00% ✅
go.viam.com/rdk/examples/customresources/demos/remoteserver 0% 0.00% ❌
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/internal/cloud 100% 0.00% ✅
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 67% 0.00% ➖
go.viam.com/rdk/module 75% 0.00% ✅
go.viam.com/rdk/module/modmanager 82% 0.00% ✅
go.viam.com/rdk/motionplan 78% -1.53% ✅
go.viam.com/rdk/motionplan/tpspace 78% 0.00% ✅
go.viam.com/rdk/operation 83% 0.00% ✅
go.viam.com/rdk/pointcloud 67% 0.00% ➖
go.viam.com/rdk/protoutils 49% 0.00% ❌
go.viam.com/rdk/referenceframe 65% 0.00% ➖
go.viam.com/rdk/resource 77% 0.00% ✅
go.viam.com/rdk/rimage 55% 0.00% ➖
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 72% +0.09% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 86% 0.00% ✅
go.viam.com/rdk/robot/client 82% 0.00% ✅
go.viam.com/rdk/robot/framesystem 36% 0.00% ❌
go.viam.com/rdk/robot/impl 83% 0.00% ✅
go.viam.com/rdk/robot/packages 75% 0.00% ✅
go.viam.com/rdk/robot/server 55% 0.00% ➖
go.viam.com/rdk/robot/web 65% 0.00% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol 50% 0.00% ➖
go.viam.com/rdk/services/baseremotecontrol/builtin 81% 0.00% ✅
go.viam.com/rdk/services/datamanager 65% 0.00% ➖
go.viam.com/rdk/services/datamanager/builtin 89% 0.00% ✅
go.viam.com/rdk/services/datamanager/datacapture 73% 0.00% ✅
go.viam.com/rdk/services/datamanager/datasync 0% 0.00% ❌
go.viam.com/rdk/services/mlmodel 76% 0.00% ✅
go.viam.com/rdk/services/mlmodel/tflitecpu 85% 0.00% ✅
go.viam.com/rdk/services/motion 52% 0.00% ➖
go.viam.com/rdk/services/motion/builtin 81% 0.00% ✅
go.viam.com/rdk/services/navigation 47% 0.00% ❌
go.viam.com/rdk/services/navigation/builtin 86% 0.00% ✅
go.viam.com/rdk/services/sensors 81% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 97% 0.00% ✅
go.viam.com/rdk/services/shell 11% 0.00% ❌
go.viam.com/rdk/services/slam 73% 0.00% ✅
go.viam.com/rdk/services/slam/fake 82% 0.00% ✅
go.viam.com/rdk/services/vision 34% 0.00% ❌
go.viam.com/rdk/services/vision/colordetector 56% 0.00% ➖
go.viam.com/rdk/services/vision/detectionstosegments 67% 0.00% ➖
go.viam.com/rdk/services/vision/mlvision 64% 0.00% ➖
go.viam.com/rdk/services/vision/obstaclesdepth 74% 0.00% ✅
go.viam.com/rdk/services/vision/obstaclesdistance 77% 0.00% ✅
go.viam.com/rdk/services/vision/obstaclespointcloud 59% 0.00% ➖
go.viam.com/rdk/session 94% 0.00% ✅
go.viam.com/rdk/spatialmath 82% -0.09% ✅
go.viam.com/rdk/utils 65% 0.00% ➖
go.viam.com/rdk/utils/contextutils 38% 0.00% ❌
go.viam.com/rdk/vision 37% 0.00% ❌
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 69% 0.00% ➖
go.viam.com/rdk/vision/segmentation 54% 0.00% ➖
go.viam.com/rdk/web/server 26% 0.00% ❌
Summary 62% (22907 / 37181) -0.79% ➖

@stevebriskin stevebriskin merged commit 377e023 into viamrobotics:main Aug 23, 2023
bazile-clyde pushed a commit to bazile-clyde/rdk that referenced this pull request Jan 5, 2024
@stevebriskin
RSDK-4414: flaky gpiostepper test fix (viamrobotics#2821)
0dae698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randhid randhid randhid approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevebriskin @randhid @viambot