APP-2115 - cloud_package_manager improvements #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
safe to test
viambot
added
safe to test
zaporter-work
changed the title
zaporter-work
commented
Jul 21, 2023
Comment on lines
44
to
+50
| return &apppb.AgentInfo{ | ||
| Host: hostname, | ||
| Ips: ips, | ||
| Os: runtime.GOOS, | ||
| Version: Version, | ||
| GitRevision: GitRevision, | ||
| Platform: &platform, |
There was a problem hiding this comment.
The rdk does not have tests for AgentInfo.
Happy to add some if others think it is worthwhile.
There was a problem hiding this comment.
Yes please add a ticket in our project epic. Doesn't have to be in this PR, unless you feel you can take it on now.
There was a problem hiding this comment.
viambot
added
safe to test
Code Coverage
|
michaellee1019
approved these changes
Jul 24, 2023
Comment on lines
44
to
+50
| return &apppb.AgentInfo{ | ||
| Host: hostname, | ||
| Ips: ips, | ||
| Os: runtime.GOOS, | ||
| Version: Version, | ||
| GitRevision: GitRevision, | ||
| Platform: &platform, |
There was a problem hiding this comment.
Yes please add a ticket in our project epic. Doesn't have to be in this PR, unless you feel you can take it on now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://viam.atlassian.net/browse/APP-2115
This PR: