Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-4074 - make errEndOfDataset public #2654

Merged
merged 3 commits into from
Jul 19, 2023
Merged

RSDK-4074 - make errEndOfDataset public #2654

merged 3 commits into from
Jul 19, 2023

Conversation

kim-mishra
Copy link
Contributor

We are matching on a string in carto code and want to match on a var so that the strings do not need to be kept in sync. This error needs to be public so we can access it there

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jul 19, 2023
@kim-mishra kim-mishra marked this pull request as ready for review July 19, 2023 17:03
@kim-mishra kim-mishra force-pushed the RSDK-4074-make-errEndOfDataset-public branch from bf25112 to 145c6de Compare July 19, 2023 18:26
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jul 19, 2023
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jul 19, 2023
@github-actions
Copy link
Contributor

Code Coverage

Code Coverage
Package Line Rate Delta Health
go.viam.com/rdk/components/arm 59% 0.00% ➖
go.viam.com/rdk/components/arm/fake 27% 0.00% ❌
go.viam.com/rdk/components/arm/universalrobots 41% 0.00% ❌
go.viam.com/rdk/components/arm/wrapper 19% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 22% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 6% 0.00% ❌
go.viam.com/rdk/components/audioinput 44% +0.47% ❌
go.viam.com/rdk/components/base 60% 0.00% ➖
go.viam.com/rdk/components/base/agilex 61% 0.00% ➖
go.viam.com/rdk/components/base/kinematicbase 41% 0.00% ❌
go.viam.com/rdk/components/base/wheeled 81% 0.00% ✅
go.viam.com/rdk/components/board 60% +0.21% ➖
go.viam.com/rdk/components/board/customlinux 71% 0.00% ✅
go.viam.com/rdk/components/board/fake 40% 0.00% ❌
go.viam.com/rdk/components/board/genericlinux 9% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi 50% 0.00% ➖
go.viam.com/rdk/components/camera 58% 0.00% ➖
go.viam.com/rdk/components/camera/align 58% 0.00% ➖
go.viam.com/rdk/components/camera/fake 74% 0.00% ✅
go.viam.com/rdk/components/camera/ffmpeg 82% 0.00% ✅
go.viam.com/rdk/components/camera/replaypcd 89% 0.00% ✅
go.viam.com/rdk/components/camera/rtsp 52% +0.87% ➖
go.viam.com/rdk/components/camera/transformpipeline 77% 0.00% ✅
go.viam.com/rdk/components/camera/ultrasonic 61% 0.00% ➖
go.viam.com/rdk/components/camera/videosource 34% 0.00% ❌
go.viam.com/rdk/components/encoder 57% 0.00% ➖
go.viam.com/rdk/components/encoder/ams 63% 0.00% ➖
go.viam.com/rdk/components/encoder/fake 83% 0.00% ✅
go.viam.com/rdk/components/encoder/incremental 80% 0.00% ✅
go.viam.com/rdk/components/encoder/single 86% 0.00% ✅
go.viam.com/rdk/components/gantry 60% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 82% 0.00% ✅
go.viam.com/rdk/components/gantry/singleaxis 81% 0.00% ✅
go.viam.com/rdk/components/generic 79% 0.00% ✅
go.viam.com/rdk/components/gripper 69% 0.00% ➖
go.viam.com/rdk/components/input 88% 0.00% ✅
go.viam.com/rdk/components/input/fake 94% +1.49% ✅
go.viam.com/rdk/components/input/gpio 85% 0.00% ✅
go.viam.com/rdk/components/motor 71% 0.00% ✅
go.viam.com/rdk/components/motor/dimensionengineering 67% 0.00% ➖
go.viam.com/rdk/components/motor/dmc4000 70% 0.00% ➖
go.viam.com/rdk/components/motor/fake 55% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 73% 0.00% ✅
go.viam.com/rdk/components/motor/gpiostepper 57% 0.00% ➖
go.viam.com/rdk/components/motor/tmcstepper 53% 0.00% ➖
go.viam.com/rdk/components/motor/ulnstepper 53% 0.00% ➖
go.viam.com/rdk/components/movementsensor 69% 0.00% ➖
go.viam.com/rdk/components/movementsensor/adxl345 75% 0.00% ✅
go.viam.com/rdk/components/movementsensor/cameramono 42% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsnmea 58% +3.19% ➖
go.viam.com/rdk/components/movementsensor/merged 91% 0.00% ✅
go.viam.com/rdk/components/movementsensor/mpu6050 84% 0.00% ✅
go.viam.com/rdk/components/movementsensor/rtkutils 24% 0.00% ❌
go.viam.com/rdk/components/posetracker 71% 0.00% ✅
go.viam.com/rdk/components/sensor 51% 0.00% ➖
go.viam.com/rdk/components/sensor/ultrasonic 38% 0.00% ❌
go.viam.com/rdk/components/servo 62% 0.00% ➖
go.viam.com/rdk/components/servo/gpio 72% 0.00% ✅
go.viam.com/rdk/config 79% 0.00% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 77% 0.00% ✅
go.viam.com/rdk/examples/customresources/demos/remoteserver 0% 0.00% ❌
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/internal/cloud 100% 0.00% ✅
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 71% 0.00% ✅
go.viam.com/rdk/module 75% 0.00% ✅
go.viam.com/rdk/module/modmanager 82% 0.00% ✅
go.viam.com/rdk/motionplan 79% +0.27% ✅
go.viam.com/rdk/motionplan/tpspace 78% 0.00% ✅
go.viam.com/rdk/operation 82% 0.00% ✅
go.viam.com/rdk/pointcloud 66% 0.00% ➖
go.viam.com/rdk/protoutils 49% 0.00% ❌
go.viam.com/rdk/referenceframe 65% 0.00% ➖
go.viam.com/rdk/resource 76% 0.00% ✅
go.viam.com/rdk/rimage 55% 0.00% ➖
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 71% -0.09% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 85% -0.87% ✅
go.viam.com/rdk/robot/client 82% 0.00% ✅
go.viam.com/rdk/robot/framesystem 36% 0.00% ❌
go.viam.com/rdk/robot/impl 83% +0.37% ✅
go.viam.com/rdk/robot/packages 80% 0.00% ✅
go.viam.com/rdk/robot/server 55% 0.00% ➖
go.viam.com/rdk/robot/web 65% +0.16% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol 50% 0.00% ➖
go.viam.com/rdk/services/baseremotecontrol/builtin 81% 0.00% ✅
go.viam.com/rdk/services/datamanager 65% 0.00% ➖
go.viam.com/rdk/services/datamanager/builtin 89% +0.97% ✅
go.viam.com/rdk/services/datamanager/datacapture 73% 0.00% ✅
go.viam.com/rdk/services/datamanager/datasync 0% 0.00% ❌
go.viam.com/rdk/services/mlmodel 83% 0.00% ✅
go.viam.com/rdk/services/mlmodel/tflitecpu 82% 0.00% ✅
go.viam.com/rdk/services/motion 48% 0.00% ❌
go.viam.com/rdk/services/motion/builtin 83% 0.00% ✅
go.viam.com/rdk/services/navigation 49% 0.00% ❌
go.viam.com/rdk/services/navigation/builtin 57% 0.00% ➖
go.viam.com/rdk/services/sensors 81% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 97% 0.00% ✅
go.viam.com/rdk/services/shell 11% 0.00% ❌
go.viam.com/rdk/services/slam 79% 0.00% ✅
go.viam.com/rdk/services/slam/fake 82% 0.00% ✅
go.viam.com/rdk/services/vision 35% 0.00% ❌
go.viam.com/rdk/services/vision/colordetector 56% 0.00% ➖
go.viam.com/rdk/services/vision/detectionstosegments 67% 0.00% ➖
go.viam.com/rdk/services/vision/mlvision 67% 0.00% ➖
go.viam.com/rdk/services/vision/obstacledistance 77% 0.00% ✅
go.viam.com/rdk/services/vision/radiusclustering 59% 0.00% ➖
go.viam.com/rdk/session 94% 0.00% ✅
go.viam.com/rdk/spatialmath 82% +0.27% ✅
go.viam.com/rdk/utils 68% 0.00% ➖
go.viam.com/rdk/utils/contextutils 38% 0.00% ❌
go.viam.com/rdk/vision 32% 0.00% ❌
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 69% 0.00% ➖
go.viam.com/rdk/vision/odometry 60% 0.00% ➖
go.viam.com/rdk/vision/odometry/cmd 0% 0.00% ❌
go.viam.com/rdk/vision/segmentation 49% 0.00% ❌
go.viam.com/rdk/web/server 26% 0.00% ❌
Summary 65% (21664 / 33517) +0.89% ➖

@kim-mishra kim-mishra removed the request for review from jeremyrhyde July 19, 2023 20:54
@kim-mishra kim-mishra merged commit c10eab2 into viamrobotics:main Jul 19, 2023
@kim-mishra kim-mishra deleted the RSDK-4074-make-errEndOfDataset-public branch July 19, 2023 20:54
bazile-clyde pushed a commit to bazile-clyde/rdk that referenced this pull request Jan 5, 2024
@kim-mishra
RSDK-4074 - make errEndOfDataset public (viamrobotics#2654)
262ca28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicksanford nicksanford nicksanford approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kim-mishra @nicksanford @viambot