Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Storybook #612

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Remove Storybook #612

merged 2 commits into from
Dec 20, 2024

Conversation

micheal-parks
Copy link
Member

@micheal-parks micheal-parks commented Dec 19, 2024 •
edited
Loading

Overview

prime.viam.com is dead, and the migration to astro is complete. We are free.

ethanlookpotts
ethanlookpotts approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@ethanlookpotts ethanlookpotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! This is great news!

Not for this PR, just thinking out loud: I'm wondering if we should set up a redirect from prime.viam.com to design.viam.com? Thoughts?

Also, just to double check - did you run pnpm dedupe to clean up the lockfile?

@micheal-parks
Copy link
Member Author

@ethanlookpotts Forgot, thanks for the reminder!

As far as redirects go I believe @mrloureed requested but Steve didn't want to? Not sure if I got the full story there.

@micheal-parks micheal-parks merged commit 6c4a7fe into viamrobotics:main Dec 20, 2024
4 checks passed
@micheal-parks micheal-parks deleted the remove-storybook branch December 20, 2024 20:14
@mcous mcous mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanlookpotts ethanlookpotts ethanlookpotts approved these changes

@mrloureed mrloureed Awaiting requested review from mrloureed

@mcous mcous Awaiting requested review from mcous

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micheal-parks @ethanlookpotts