Break words in SearchableSelect value & description #580
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaporter-work
force-pushed
the
zp/break-words
branch
from
40c88bc
to
6cb19bd
Compare
zaporter-work
force-pushed
the
zp/break-words
branch
from
6cb19bd
to
cbfd8b3
Compare
zaporter-work
commented
Sep 19, 2024
| <p class="text-wrap text-sm"> | ||
| <div | ||
| class="flex flex-col" | ||
| style="overflow-wrap: anywhere;" |
There was a problem hiding this comment.
Tailwind hasn't merged an alternative to word-break: break-word. All other word-breaking combinations that I tried had issues.
See discussion: tailwindlabs/tailwindcss#12127
See PR: tailwindlabs/tailwindcss#12128
There was a problem hiding this comment.
I'm cool with this, but can we do it as a tailwind arbitrary-inside-brackets class instead of an inline style?
| class="flex flex-col" | ||
| style="overflow-wrap: anywhere;" | ||
| > | ||
| <p class="text-sm"> |
There was a problem hiding this comment.
text-wrap not required.
mcous
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know we are deprecating
SearchableSelect. However, thevideo-pathdropdown for the webcam component builder has caused me enough emotional pain to just come fix this. Thoughts?Before:
After:
