APP-2280 Add @viamrobotics/prime-core package #282
Conversation
ethanlook
force-pushed
the
APP-2280-core
branch
3 times, most recently
from
c14f644
to
db4aff5
Compare
.github/workflows/ci.yml
Outdated
| with: | ||
| name: npm-core-dist | ||
| path: packages/core/dist | ||
| - name: Publish @viamrobotics/prime-core 🚀 |
There was a problem hiding this comment.
For followup work, it may be worth switching from JS-DevTools/npm-publish to pnpm publish --recursive. This would let us publish everything in one go (if a package's version is not yet published) with some added niceties, like copying a root LICENSE file into all published packages
packages/core/vite.config.ts
Outdated
| plugins: [sveltekit()], | ||
| test: { | ||
| include: ['src/**/*.{test,spec}.{js,ts}'], | ||
| globals: true, |
There was a problem hiding this comment.
Rather than setting globals: true, we can set up a vitest.setup.ts file to install @testing-library/jest-dom and configure the testing-library reset. I softly prefer it to globals mode which feels to me like a silly holdover from pre-module times
ethanlook
force-pushed
the
APP-2280-core
branch
4 times, most recently
from
abbbbc8
to
5da9b0f
Compare
ethanlook
force-pushed
the
APP-2280-core
branch
2 times, most recently
from
510412e
to
0ad645d
Compare
| with: | ||
| node-version: 18 | ||
| - name: Download npm artifacts | ||
| node-version: 16 |
There was a problem hiding this comment.
Node 16 is EOL'ing in a few months; was this change intentional?
There was a problem hiding this comment.
Nope - copy pasta
| @@ -8,7 +10,10 @@ module.exports = { | |||
| parserOptions: { | |||
| tsConfigRootDir: __dirname, | |||
There was a problem hiding this comment.
Is this casing correct?
| tsConfigRootDir: __dirname, | |
| tsconfigRootDir: __dirname, |
There was a problem hiding this comment.
It was not! Great catch.
| path.join(__dirname, './tsconfig.json'), | ||
| path.join(__dirname, './playground/tsconfig.json'), |
There was a problem hiding this comment.
These path.join's shouldn't be required; might be related to casing comment above
There was a problem hiding this comment.
Unfortunately the casing did not affect the need for the path.joins. Leaving as-is.
| @@ -67,6 +63,7 @@ | |||
| "@typescript-eslint/parser": "^5.59.0", | |||
| "@viamrobotics/eslint-config": "^0.0.4", | |||
| "@viamrobotics/prettier-config": "^0.0.1", | |||
| "@viamrobotics/prime-core": "workspace:../core", | |||
There was a problem hiding this comment.
Oh duh, hadn't considered that we'd added a workspace dependency. This makes our usage of pnpm publish -r required rather than "nice to have" (to replace workspace deps with the actual versions).
Glad you took care of that!
There was a problem hiding this comment.
I just added this dependency so we could share the theme across packages, but we didn't do that when you first reviewed. It's much better now anyways!
This adds a new
@viamrobotics/prime-corepackage to PRIME. The package is a SvelteKit component library.Change log
npm create svelte@latest coreTesting
BadgetestsReview requests
Please try to pull down the branch and see if you can use the component in your own local work. Instructions are in the README.