-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APP-2072 Move prime to packages/legacy in a pnpm workspace. #269
APP-2072 Move prime to packages/legacy in a pnpm workspace. #269
Conversation
|
||
PRIME is a collection of atomic UI elements, designed to "just work" in any HTML-based environment, regardless of framework or lack thereof. It is a web component library. | ||
## Packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please read this section as "to be added soon" 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
1016173
to
636df87
Compare
@DTCurrie Can you try again? Did you |
0498fc2
to
ef4efdd
Compare
I did do a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-org looks great! I think these should be all the changes we need to get publishing working with the new structure.
While testing, you can use the dry-run
input on the publish step (along with messing with the if
) to verify the correct stuff will get published
ed1db16
to
9c55c14
Compare
23b3726
to
594e85b
Compare
ad090eb
to
80ba445
Compare
80ba445
to
99fb4e2
Compare
I validated with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Overview
This PR restructures PRIME to use pnpm workspaces according to the proposal in this wiki. The
@viamrobotics/prime
package will remain stable for now during our migration to the new structure. This package will be removed once we've completed the move and applications no longer depend on@viamrobotics/prime
.Test Plan
Changelog
pnpm-workspace.yaml
packages/legacy
Review requests
Please pull down this branch and test your normal workflows with PRIME and make sure they work as expected.