Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-2072 Move prime to packages/legacy in a pnpm workspace. #269

Merged

Conversation

ethanlookpotts
Copy link
Contributor

Overview

This PR restructures PRIME to use pnpm workspaces according to the proposal in this wiki. The @viamrobotics/prime package will remain stable for now during our migration to the new structure. This package will be removed once we've completed the move and applications no longer depend on @viamrobotics/prime.

Test Plan

  • Verified existing commands work as expected (playground, storybook, etc)

Changelog

  • Added pnpm-workspace.yaml
  • Moved package under packages/legacy
    • Fixed all path resolution
  • Updated READMEs, added new top-level README
  • Updated Github Workflows

Review requests

Please pull down this branch and test your normal workflows with PRIME and make sure they work as expected.


PRIME is a collection of atomic UI elements, designed to "just work" in any HTML-based environment, regardless of framework or lack thereof. It is a web component library.
## Packages
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read this section as "to be added soon" 😄

Copy link
Member

@mrloureed mrloureed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@DTCurrie
Copy link
Member

I can't run pnpm build in packages/legacy and I am seeing this with pnpm storybook:

Screenshot 2023-07-24 at 10 43 58 AM

@ethanlookpotts
Copy link
Contributor Author

I can't run pnpm build in packages/legacy and I am seeing this with pnpm storybook:

@DTCurrie Can you try again? Did you pnpm install?

@DTCurrie
Copy link
Member

I can't run pnpm build in packages/legacy and I am seeing this with pnpm storybook:

@DTCurrie Can you try again? Did you pnpm install?

I did do a pnpm install. I will try again later today.

Copy link
Member

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-org looks great! I think these should be all the changes we need to get publishing working with the new structure.

While testing, you can use the dry-run input on the publish step (along with messing with the if) to verify the correct stuff will get published

.npmignore Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
packages/legacy/package.json Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/legacy/package.json Outdated Show resolved Hide resolved
packages/legacy/package.json Outdated Show resolved Hide resolved
@ethanlookpotts ethanlookpotts force-pushed the APP-2072-pnpm-workspace-legacy branch 2 times, most recently from 23b3726 to 594e85b Compare July 25, 2023 20:08
@ethanlookpotts ethanlookpotts force-pushed the APP-2072-pnpm-workspace-legacy branch 3 times, most recently from ad090eb to 80ba445 Compare July 25, 2023 20:33
@ethanlookpotts
Copy link
Contributor Author

While testing, you can use the dry-run input on the publish step (along with messing with the if) to verify the correct stuff will get published

I validated with dry-run that the correct files would get published. Thank you for the recommendation!

Copy link
Member

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ethanlookpotts ethanlookpotts merged commit f54245e into viamrobotics:main Jul 25, 2023
5 checks passed
@ethanlookpotts ethanlookpotts deleted the APP-2072-pnpm-workspace-legacy branch September 12, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants