Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App 2049 icons update #267

Merged
merged 26 commits into from
Jul 18, 2023
Merged

Conversation

mrloureed
Copy link
Member

Update icon library to use @mdi/js

Audit current icon set

@mrloureed
Copy link
Member Author

mrloureed commented Jul 10, 2023

@nathartman How do you like this iteration of the current icon set in Prime? I tried to make more consistent and use outline versions where it made sense. That being said, I'm happy to do whatever you suggest!

image

Current set: https://prime.viam.com/?path=/docs/elements-icon--docs

@nathartman
Copy link
Contributor

Looks great from what I can tell! Yay

@mrloureed
Copy link
Member Author

Here is the final set @nathartman ... there are some knock out versions of alert-circle and check-circle used in payment and billing, so I kept them for now. Holler if you want this changed.

image

package.json Outdated
@@ -95,5 +95,9 @@
"vite": "4.3.1",
"vue": "^3.2.45",
"vue-tsc": "^1.2.0"
},
"dependencies": {
"@mdi/js": "^7.2.96",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be devDependencies since we don't want them added into the node_modules of anything downstream like app or rc

aria-labelledby="name"
role="img"
>
{#if sizes[size]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to check for size here?


let fill = '';

switch (variant) {
Copy link
Member

@micheal-parks micheal-parks Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should wrap this in a $ so that it's reactive (e.g. if a user updates the variant prop we'd want fill to update)

$: {
  switch (variant) { ... }
  
  if (isDisabled) { ... }
}

@mrloureed mrloureed marked this pull request as ready for review July 17, 2023 16:51
@mrloureed mrloureed merged commit 5b121af into viamrobotics:main Jul 18, 2023
@mrloureed mrloureed deleted the APP-2049-icons-update branch July 18, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants