Design maintenance Jul 7 2023 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What was the fix for the notify "art" bug? |
|
We restructured slots to be more intuitive, but this will actually require a follow up in app. There's an example added that creates a notification that would exist on the history page without that visual bug 🎉 (it was a flexbox + slot issue) |
mrloureed
approved these changes
Jul 10, 2023
| title='This is the title.' | ||
| message='This is the message.' | ||
| title='You have an incoming life update' | ||
| message='LifeOS has been upgraded to a new version that includes great new things such as friends and family and you will not be alone anymore.' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done in a session with nat. Mostly involves notification and modal tweaks.