-
Notifications
You must be signed in to change notification settings - Fork 48
DOCS-4050: Add module configuration details #4375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@@ -106,14 +106,20 @@ Examples: | |||
"type": "registry", | |||
"name": "viam_tflite_cpu", | |||
"module_id": "viam:tflite_cpu", | |||
"version": "latest" | |||
"version": "latest", | |||
"disabled": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This strikes me as not a great example. If someone were to copy this it would be disabled...
Maybe false would be better? Shows the option but it's then usable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since false is the default, there'd be no reason to use the attribute in the "true" case. The other 3 modules in this example block are enabled so I think it makes sense to do it this way to demonstrate the optionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you approved I'll take it this is up to my discretion? Going to fix the merge conflicts and then merge
🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs' |
No description provided.