Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the C++ module creation docs to reflect new data type #3774

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

lia-viam
Copy link
Contributor

Edits the module how-to to reflect the replacement of AttributeMap with ProtoStruct

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Dec 20, 2024
@viambot
Copy link
Member

viambot commented Dec 20, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3774

@JessamyT JessamyT self-requested a review December 30, 2024 18:42
Copy link
Collaborator

@JessamyT JessamyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this has been tested, go ahead and merge. TYSM for updating!

@lia-viam
Copy link
Contributor Author

lia-viam commented Jan 2, 2025

@JessamyT what does testing entail? I checked the docs-test version and it looks good but not sure if there's other checks I missed

@JessamyT
Copy link
Collaborator

JessamyT commented Jan 2, 2025

@lia-viam I just mean from an eng perspective, if you're sure this code works go for it.

@lia-viam lia-viam merged commit a6bc214 into viamrobotics:main Jan 2, 2025
10 checks passed
@lia-viam lia-viam deleted the proto-struct-update branch January 2, 2025 19:21
Copy link

github-actions bot commented Jan 2, 2025

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants