Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0 edits #3743

Merged
merged 15 commits into from
Dec 16, 2024
Merged

v3.0 edits #3743

merged 15 commits into from
Dec 16, 2024

Conversation

sguequierre
Copy link
Collaborator

@sguequierre sguequierre commented Dec 9, 2024

IA edits for data and ai

Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good start - definitely moving in the right direction. I've only done a superficial review and will do more once you're further along

Comment on lines 15 to 18
You can use Viam's built-in data management service to capture images from a camera on your machine and sync the images to the cloud.

With your images synced to the cloud, you can view images from all your machines in the Viam app interface.
From there, you can use your image data to do things like [train ML models](/how-tos/train-deploy-ml/).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this file isn't done yet - since it talks about images? Will skip to the next


{{< /alert >}}

## Prerequisites: Teleop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think have a heading ## Teleop and then H3s for the sub-headings to avoid this. Then you can also briefly intro both


## Configure a sensor widget

Follow our docs to [configure a teleop workspace](manage/troubleshoot/teleoperate/).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to have the instructions here instead, copy them or create an include

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied over bc needed some adjustments

{{% /tablestep %}}
{{< /table >}}

## Configure data query
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird here - the user would get confused why they are asked to do this. See the visualize.md file comments for h2 and h3s

Comment on lines 23 to 27
{{% alert title="In this page" color="tip" %}}

- [Export data with the Viam CLI](#export-data-with-the-viam-cli)

{{% /alert %}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can get rid of these, since the TOC is now in the left hand nav

Suggested change
{{% alert title="In this page" color="tip" %}}
- [Export data with the Viam CLI](#export-data-with-the-viam-cli)
{{% /alert %}}

Comment on lines 11 to 13
Collect images from your machine as it monitors its environment and add these images to a dataset.
By creating a dataset from your images, you can then train a machine learning model.
To ensure the model you create performs well, you need to train it on a variety of images that cover the range of things your machine should be able to recognize.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intro here needs work

---

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering here if we should merge relevant bits from the ML model service page into this and then get rid of that page in the reference section. It feels somewhat possible? Wondering the same about the vision service and data mgmt service tbh but this seems a good place to start

And maybe also cover https://docs.viam.com/registry/ml-models/#model-framework-support ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, that seems to have worked. Now let's see if we can do the same for vision service and data management service


For more detailed information, including optional attribute configuration, see the [`mlmodel` docs](/services/vision/mlmodel/).

## Use an SDK
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, I think we could possibly add a code sample here before pointing to APIs?


Note that your machine must be connected to the internet for data sync and email notifications to work.

## Set up your monitor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like I said yesterday, this feels weird - let's iterate

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry this edit slipped my mind, will make it


{{% snippet "setup.md" %}}

## Configure the camera and computer vision
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there's room here for discussions but I think we can consider this as a follow on from the pages before this. So I think you may be able to shorten these steps - until you get to the filtered-camera module

@sguequierre sguequierre requested a review from npentrel December 12, 2024 16:59

You can also access data from a resource or machine part menu.

## Next steps
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

veer towards keeping this here bc still helpful... thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep it for now

Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - I think merge this as is and address the feedback in a separate PR. This is coming together quite nicely. I think next week may be a good time for you to gather feedback from Jack & Tahiya / others on this. And maybe late next week would be good to run this by Bill if he has time (I'd like to be there for that one)

docs/data-ai/get-started/capture-sync.md Outdated Show resolved Hide resolved
Comment on lines +14 to +18
Once you have configured the data management service, you can specify the data you want to capture at a resource level.

To configure data capture and cloud sync, you must have one of the following components and services configured on your machine:

{{< readfile "/static/include/data/capture-supported.md" >}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't really make sense to have the methods in this table at this point when you just want to say which components and services are supported. I think it's probably best to put what is supported later in this page and keep the requirement up front to more minimal. Also remember you can use the data management service to just sync arbitrary files that something is creating on a machine. Without any configured components.

How about something like:

Suggested change
Once you have configured the data management service, you can specify the data you want to capture at a resource level.
To configure data capture and cloud sync, you must have one of the following components and services configured on your machine:
{{< readfile "/static/include/data/capture-supported.md" >}}
You can capture data from [supported components and services](#link-to-table-that-is-later-in-the-page) or from arbitrary folders on your machines.


## Configure the data management service

To start, configure a data management service to capture and sync the resource data.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can only configure one. And like I said above, it's not restricted to resources.

Suggested change
To start, configure a data management service to capture and sync the resource data.
To start, configure the data management service to capture and sync data.


{{< imgproc src="/tutorials/data-management/data-management-conf.png" alt="Data capture configuration card." resize="600x" >}}

For more advanced attribute configuration information, see [Data management service configuration](/data-ai/reference/data/#data-management-service-configuration).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you already tried moving more of the service pages into these guides and decided against it or are you waiting to do that later in a different PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally envisioned having these pages be simpler versions of the reference docs (closer to the how-tos) but still keeping the reference docs up bc that info is also necessary. Does that make sense?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense. if we need to keep them then so be it - just want to check that there's actually still info in there we don't already cover


## Configure data capture

Scroll to the config card you wish to configure data capture and sync on.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Scroll to the config card you wish to configure data capture and sync on.
Scroll to the resource card you wish to configure data capture and sync on.

---

At this point, you should have already set up and tested [computer vision functionality](/data-ai/ai/run-inference/).
On this page, you'll learn how to use triggers to send alerts in the form of email notifications when certain detections or classifications are made.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need to capture both email & webhooks. webhooks are almost certainly the more sought after part

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly we want to put the webhook info into and include and put that on all of the multiple alert pages...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean the webhook info from the helmet tutorial to /data-ai/data/advanced/alert-data/? IMO that seems like a lot of info to add/could overwhelm the page but I can add it if you think necessary

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up doing it like this here: https://docs-test.viam.dev/3723/manage/troubleshoot/alert/#webhooks just so that we also cover webhooks. The emails are nice but I think more people will need webhooks than emails so we need to mention them and provide the info for it. I think maybe we need to have a webhook reference page or something that we can then link to from the three pages. Or use this as an include and put it in all the places where this comes up

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made it into an include

First, you'll set up data capture and sync to record images with the anomaly and upload them to the cloud.
Next, you'll configure a trigger to send email notifications when the anomaly is detected.

## Configured a filtered camera
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Configured a filtered camera
## Configure a filtered camera


## Configured a filtered camera

Your physical camera is working and your vision service is set up.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a prerequisites section please, that way this page follows the general pattern we use on other pages

---

You can use the [vision service API](/dev/reference/apis/services/vision/) to get information about your machine's inferences and program behavior based on that.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think worth you chatting with Jack and Tahiya about whether we want to introduce the vision service here as one of many possible services you could use.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs more work in intro to explain that we'll show a few examples here only


You can use the following code to detect and follow the location of a colored object:

{{% expand "click to view code" %}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capitalization

@sguequierre sguequierre merged commit bb06e29 into viamrobotics:v3.0 Dec 16, 2024
4 of 7 checks passed
@sguequierre sguequierre deleted the v3.0-edits branch December 16, 2024 16:10
@sguequierre sguequierre restored the v3.0-edits branch December 16, 2024 16:11
npentrel added a commit that referenced this pull request Jan 7, 2025
Co-authored-by: Naomi Pentrel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants