Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-2557: Add architecture to platform reference page #3251

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

JessamyT
Copy link
Collaborator

@JessamyT JessamyT commented Aug 13, 2024

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Aug 13, 2024
@JessamyT JessamyT requested a review from npentrel August 13, 2024 22:50
docs/platform.md Outdated
Some are built-in, and many more are available in the registry.
You can also write your own and add them to the registry.

In addition to modular components and services, the registry contains ML models.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In addition to modular components and services, the registry contains ML models.

True but also training scripts. I think let's gloss over this

docs/platform.md Outdated
Comment on lines 32 to 37
{{< cards >}}
{{% card link="/architecture/" %}}
{{% card link="/configure/" %}}
{{% card link="/fleet/" %}}
{{% card link="/cloud/" %}}
{{% card link="/fleet/" %}}
{{< /cards >}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the cards aren't actually helpful here and just take up space, let's take them out and just use the table

docs/platform.md Outdated
Comment on lines 47 to 51
{{< cards >}}
{{% card link="/components/" %}}
{{% card link="/services/" %}}
{{% card link="/registry/" %}}
{{< /cards >}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could try how it looks with smaller cards and listing these out something like

Suggested change
{{< cards >}}
{{% card link="/components/" %}}
{{% card link="/services/" %}}
{{% card link="/registry/" %}}
{{< /cards >}}
On your machine, you can configure the following components:
{{< cards >}}
{{% relatedcard link="/components/arm" %}}
{{% relatedcard link="/components/base" %}}
{{% relatedcard link="/components/board" %}}
{{% relatedcard link="/components/camera" %}}
{{% relatedcard link="/components/encoder" %}}
{{% relatedcard link="/components/gantry" %}}
{{% relatedcard link="/components/generic" %}}
{{% relatedcard link="/components/gripper" %}}
{{% relatedcard link="/components/input-controller" %}}
{{% relatedcard link="/components/motor" %}}
{{% relatedcard link="/components/movement-sensor" %}}
{{% relatedcard link="/components/power-sensor" %}}
{{% relatedcard link="/components/sensor" %}}
{{% relatedcard link="/components/servo" %}}
{{< /cards >}}
And you can use the following platform capabilities and services to make your machines smarter and better:
{{< cards >}}
{{% relatedcard link="/services/data" %}}
{{% relatedcard link="/services/ml" %}}
{{% relatedcard link="/services/motion" %}}
{{% relatedcard link="/services/navigation" %}}
{{% relatedcard link="/services/slam" %}}
{{% relatedcard link="/services/vision" %}}
{{< /cards >}}
...

@JessamyT JessamyT requested a review from npentrel August 15, 2024 02:39
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@@ -3,7 +3,7 @@ title: "Components"
linkTitle: "Components"
weight: 410
type: docs
description: "In-depth information on the various components available within the Viam system."
description: "Components are software packages that drive hardware such as sensors, motors, cameras, and robotic arms."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two comments remaining, then good to merge. Good work, this is a big improvement

@viambot
Copy link
Member

viambot commented Aug 15, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3251

@JessamyT JessamyT merged commit 232f859 into viamrobotics:main Aug 15, 2024
9 checks passed
@JessamyT JessamyT deleted the 2557platfarch branch August 15, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants