Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-2670: Make new model training gif #3250

Merged

Conversation

sguequierre
Copy link
Collaborator

  • train pac man ghosts dataset from viam devrel demos
  • goes through whole process with auto-labeling

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Aug 13, 2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this gif should actually be longer/show the page, I think preview is just slightly off. unsure how to fix

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you used the command to make the preview gif, which just takes the first few seconds of a video and makes a gif. Use Kap or ezgi to manually make a gif that is suitable.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also

  • reduce screen width so the video & gifs aren't needlessly wide
  • remove needless cursor movement - re-record or cut it
  • speed up the video, people can take in information faster than the recording, so generally good to increase speed to at least 150%

JessamyT
JessamyT previously approved these changes Aug 13, 2024
Copy link
Collaborator

@JessamyT JessamyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm in the rendered site the GIF is stretched horizontally a little bit. Not sure what's going on there. Mind following up after merging to see if it's still doing that in prod, and if it is, try messing with the formatting?

@npentrel npentrel dismissed JessamyT’s stale review August 14, 2024 09:44

not actually good

Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments.

@sguequierre sguequierre requested a review from npentrel August 14, 2024 15:14
@viambot
Copy link
Member

viambot commented Aug 14, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3250

@sguequierre sguequierre requested a review from JessamyT August 14, 2024 18:24
Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks great!

@sguequierre sguequierre merged commit 0a44f85 into viamrobotics:main Aug 15, 2024
9 checks passed
@sguequierre sguequierre deleted the DOCS-2670/new-train-model-page branch August 15, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants