fix: block Sentry Replay for table class #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to build
HipsterBrown
commented
Dec 20, 2023
Comment on lines
+13
to
+19
| integrations: [ | ||
| new Sentry.Replay({ | ||
| block: ['.table'], | ||
| maskAllText: false, | ||
| blockAllMedia: false, | ||
| }), | ||
| ], |
There was a problem hiding this comment.
The spacing changes and other formatting happened automatically by my editor. Let me know if you'd like me to revert those changes.
HipsterBrown
force-pushed
the
nhehr/block-sentry-table-replay
branch
from
00fd82f to
4fb8a39
Compare
npentrel
approved these changes
Dec 20, 2023
|
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/2347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As I was reading through the module creation docs, I noticed that switching tabs for each supported programming language has a noticeable delay. When I traced the performance of that feature using the browser devtools, much of the time is taken up by the JavaScript for the Sentry Replay monitor. This is a known issue:
Following their recommendation to use the blocking feature of their SDK, I updated the configuration to block the
.tableclass surrounding this tab nav feature.Before:
slow-docs-tabs.webm
After:
fast-docs-tabs.webm