logger, sleep, exit

subsystems/viamagent/viamagent.go

@@ -41,10 +41,12 @@ var (
 	serviceFileContents []byte
 )
 
-type agentSubsystem struct{}
+type agentSubsystem struct {
+	logger logging.Logger
+}
 
 func NewSubsystem(ctx context.Context, logger logging.Logger, updateConf *pb.DeviceSubsystemConfig) (subsystems.Subsystem, error) {
-	return agent.NewAgentSubsystem(ctx, subsysName, logger, &agentSubsystem{})
+	return agent.NewAgentSubsystem(ctx, subsysName, logger, &agentSubsystem{logger: logger})
 }
 
 // Start does nothing (we're already running as we ARE the agent.)
@@ -72,13 +74,16 @@ func (a *agentSubsystem) Update(ctx context.Context, cfg *pb.DeviceSubsystemConf
 
 	expectedPath := filepath.Join(agent.ViamDirs["bin"], subsysName)
 	if runtime.GOOS == "windows" {
+		a.logger.Info("windows postinstall")
 		// no systemd on windows -- for now you need to double-restart.
 		if _, err := exec.Command(expectedPath, "--version").Output(); err != nil {
 			return false, errw.Wrap(err, "testing binary")
 		}
+		a.logger.Info("windows okay test binary")
 		if err := agent.RequestRestart(); err != nil {
 			return false, err
 		}
+		a.logger.Info("windows requested restart")
 		return true, nil
 	}
 

utils_windows.go

@@ -2,7 +2,9 @@ package agent
 
 import (
 	"io/fs"
+	"os"
 	"syscall"
+	"time"
 
 	"github.com/pkg/errors"
 )
@@ -48,5 +50,7 @@ func RequestRestart() error {
 		return errors.New("globalcancel is nil, can't restart")
 	}
 	GlobalCancel()
+	time.Sleep(5 * time.Second) // todo: rearchitect to wait for exit
+	os.Exit(1)                  // non-zero exit code to trigger service restart; test whether this is necessary
 	return nil
 }