Load generator #864
Load generator #864
Conversation
|
Hey Arun, first of all thanks for all the huge amount of effort. I'm really impressed 👏!! The python files look really impressive. High-quality code and comments! I have to spend a bit more time on it. It's a lot of changes. Most importantly you first need to rebase the branch to the latest main. Then, a lot of changed files will go away automatically. See my other comments. Also, we need to add a CI but I can help you with that :) |
| @@ -47,7 +47,7 @@ jobs: | |||
| go-version: '1.21' | |||
|
|
|||
| - name: Install Protoc | |||
| uses: arduino/setup-protoc@v2 | |||
| uses: arduino/setup-protoc@v3 | |||
There was a problem hiding this comment.
This should not be in this PR but I guess it will go away once you rebase
| @@ -59,7 +59,7 @@ jobs: | |||
| uses: docker/setup-buildx-action@v3 | |||
|
|
|||
| - name: Install Protoc | |||
| uses: arduino/setup-protoc@v2 | |||
| uses: arduino/setup-protoc@v3 | |||
| @@ -29,7 +29,7 @@ spec: | |||
| template: | |||
| spec: | |||
| containers: | |||
| - image: docker.io/vhiveease/relay:latest | |||
| - image: docker.io/vhiveease/relay-latency:latest | |||
There was a problem hiding this comment.
As we said we should not use a separate image for that. Also, I'm not sure you wanted to modify those yaml files. Don't you need the relay-latency in the profiler/yamls
| @@ -126,7 +126,11 @@ func runExperiment(endpoints []*endpoint.Endpoint, runDuration int, targetRPS fl | |||
| Start(TimeseriesDBAddr, endpoints, workflowIDs) | |||
|
|
|||
| timeout := time.After(time.Duration(runDuration) * time.Second) | |||
| tick := time.Tick(time.Duration(1000/targetRPS) * time.Millisecond) | |||
| d := time.Duration(1000000/targetRPS) * time.Microsecond | |||
There was a problem hiding this comment.
This is also already merged. Rebasing will remove it
tools/invoker/proto/helloworld.pb.go
Outdated
There was a problem hiding this comment.
You should not commit this file. It will be generated each automatically.
I don't know why it is there in the first place
| log.Debug("Recv from func: ", reply) | ||
| log.Debugf("Send to func: %s\n", pkt) | ||
|
|
||
| startTime := time.Now() |
There was a problem hiding this comment.
I think what you should do is have a parameter to enable the latency measurement or an environment variable.
Then you can set this parameter/variable in the yaml file.
An environment variable you might even be able to set in from the python file but I'm not sure.
tools/profiler/yamls/kn-aes-go.yaml
Outdated
| template: | ||
| spec: | ||
| containers: | ||
| - image: docker.io/vhiveease/relay:latest |
There was a problem hiding this comment.
I think you wanted to have here the relay-latency. But as said I would use a parameter.
- --profile-fn-exec or similar
tools/load-generator/README.md
Outdated
|
|
||
| ### Python packages | ||
| ```bash | ||
| pip3 install numpy jq typing matplotlib argparse PyYAML scipy |
There was a problem hiding this comment.
I think you should add this in a requirements.txt file. This makes it easier with the CI.
See https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python#requirements-file
Also, makes it easier manage dependencies automatically.
| @@ -0,0 +1,331 @@ | |||
| // MIT License | |||
| // | |||
| // Copyright (c) 2020 Dmitrii Ustiugov and EASE lab | |||
There was a problem hiding this comment.
You can change the licence in all files to 2024 vhive-ecosystem.
tools/profiler/README.md
Outdated
|
|
||
| ### Python packages | ||
| ```bash | ||
| pip3 install numpy jq typing matplotlib argparse PyYAML |
There was a problem hiding this comment.
Same here. I would put this in a requirements.txt file
…. Modified parameters of profiler - removed unnecessary yaml parameter and added parameter to pass invoker binary location. Also modified profiler to work with the new invoker. Removed unnecessary files and binaries. Added profile.json and config.json for over 150+ functions
…or them sequentially. Modified the error calculation to logarithmic scale
This branch contains the profiler tool that profiles the benchmark functions and the load generator which generates load based on given trace