Bug Fixes and Issue Resolution in Tuning-Halving #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alannair
force-pushed
the
tuning-halving-fixes
branch
2 times, most recently
from
ce18261 to
6bc2022
Compare
dhschall
approved these changes
Dec 19, 2022
Signed-off-by: Alan Nair <[email protected]>
alannair
force-pushed
the
tuning-halving-fixes
branch
from
6bc2022 to
2478429
Compare
|
@dhschall @shyamjesal I updated the PR description (it had become outdated) and reverted the unnecessary changes I made in the Readme in a new commit. Code changes are the same as before. |
shyamjesal
approved these changes
Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is analogous to PR #374. It incorporates the following into the tuning-halving benchmark.
BUCKET_NAMEhad not been configured, causing an empty string to be passed to the function (see log). This has also been fixed in this PR.Note that
os.getenv('ENV_VAR', 'DEFAULT_VAL')returnsDEFAULT_VALonly ifENV_VARis not set. This does not happen ifENV_VARis set to an empty string, which occurs whenENV_VARis created (indocker-compose.yaml) but not set to a value.