Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrate kind, Use github runners for CI #238

Merged
merged 4 commits into from
Aug 26, 2022
Merged

Upgrate kind, Use github runners for CI #238

merged 4 commits into from
Aug 26, 2022

Conversation

dhschall
Copy link
Contributor

@dhschall dhschall commented Aug 8, 2022

This should move all CI to github hosted runners to avoid failing test.
We also upgrade the kind modules

@dhschall dhschall linked an issue Aug 8, 2022 that may be closed by this pull request
CI Runners are broken #237
Closed
@dhschall dhschall force-pushed the 237-ci-runners-are-broken branch 16 times, most recently from 8cceb2b to 5fca068 Compare August 10, 2022 16:42
@shyamjesal shyamjesal force-pushed the 237-ci-runners-are-broken branch from 1d797c5 to 04e1973 Compare August 16, 2022 18:42
@dhschall dhschall force-pushed the 237-ci-runners-are-broken branch 5 times, most recently from daa0d5e to 52acfb0 Compare August 17, 2022 09:54
ustiugov
ustiugov reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just made some points but didn't have time to make a proper review.

@ustiugov
Copy link
Member

so you did make knative serving work on GH-hosted runners! bravo, guys!

@dhschall dhschall force-pushed the 237-ci-runners-are-broken branch from 52acfb0 to b2ae850 Compare August 17, 2022 16:04
dhschall and others added 3 commits August 17, 2022 10:52
@dhschall
Upgrate kind, Use github runners for CI
67daebc 
Signed-off-by: David Schall <[email protected]>
@shyamjesal @dhschall
fix KUBECONFIG env variable
a2a54e3 
change NODEPORT to 80

Signed-off-by: Shyam Jesal <[email protected]>
@dhschall
Apply new workflow to other CI tests
3ef4bf9 
Signed-off-by: David Schall <[email protected]>
@dhschall dhschall force-pushed the 237-ci-runners-are-broken branch 3 times, most recently from bf1720b to ef925b5 Compare August 17, 2022 22:28
@dhschall
Copy link
Contributor Author

dhschall commented Aug 17, 2022 •
edited
Loading

Ok so now I think its good for your proper review.

  • I fixed now all things in the knative testing. They use now the github hosted runners.
  • I applied the changes to the standalone functions (AES, Auth, Fibonacci, Hotel-app and online shop)
    • Beside online shop all of them seem to work.
    • Online shop fails in the build and does not belong to this issue but I created a new issue for it.

Other workflows are not adjusted yet. We still need to do this.
However, imho we should not fix failing benchmark but instead create separate issues for failing once.

@dhschall dhschall marked this pull request as ready for review August 17, 2022 22:34
@dhschall dhschall self-assigned this Aug 17, 2022
@dhschall dhschall added the enhancement New feature or request label Aug 17, 2022
ustiugov
ustiugov requested changes Aug 19, 2022
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Some minor issues.

Also please raise new Issues for the workloads that don't have the support of gh runners yet and mention them here. Then, please go ahead with the merge, no need for another review by me.

@dhschall
Copy link
Contributor Author

dhschall commented Aug 20, 2022 •
edited
Loading

Thanks Dmitrii! I'll finalise this once I'm back next Friday.

@dhschall dhschall force-pushed the 237-ci-runners-are-broken branch from ef925b5 to 30788a5 Compare August 26, 2022 09:16
@dhschall dhschall mentioned this pull request Aug 26, 2022
Open
16 tasks
@dhschall
Copy link
Contributor Author

This PR closes #237.
The new workflow is tested on several benchmarks and works. It needs to be applied to the remining once here #248.

@dhschall dhschall enabled auto-merge (rebase) August 26, 2022 09:46
@dhschall dhschall disabled auto-merge August 26, 2022 09:47
@dhschall dhschall merged commit 7048f1c into main Aug 26, 2022
@dhschall dhschall deleted the 237-ci-runners-are-broken branch August 26, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ustiugov ustiugov ustiugov requested changes

@shyamjesal shyamjesal Awaiting requested review from shyamjesal

Assignees

@dhschall dhschall

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Runners are broken
3 participants
@dhschall @ustiugov @shyamjesal