-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GetNodeIP to get the first ip #982
Conversation
Did you check it for operation in the case of two addresses in the subnet? We should maybe try to let the user choose the IP out of the available ones, as was proposed in the issue. |
Tested by replacing Enabling user choosing NodeIP is good, but I haven't come up with any ideas. Do you have any suggestion? |
@JooyoungPark73 I think the gvisor runner is failing again, could you please restart it? Thank you |
Solving this issue, added error handling when |
Signed-off-by: lrq619 <[email protected]>
Signed-off-by: Zou Yulin <[email protected]>
@leokondrashov Hi, could you please review this branch so we can get this branch merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command works correctly on CloudLab and CCDS cloud. Can merge
Summary
Change the bash command for getting node's private ip address
Now it would get the first ip address starting with 10.
Implementation Notes ⚒️
Change bash command implementation to:
External Dependencies 🍀
Breaking API Changes⚠️
Simply specify none (N/A) if not applicable.