-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploying Openyurt on top of kubernetes & knative #887
Conversation
bdc0839
to
5e29798
Compare
999853b
to
72eb921
Compare
fcee46d
to
a400526
Compare
Please add me as the reviewer, also, you only have two added checks here, but it should pass through all tests that was previously there |
9a73816
to
425a26e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me now, but make sure to delete the build binary file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- use Golang 1.19 everywhere. we should update it later to 1.20 but in a different PR
- add the vHive copyrights to all the source files
- I suggest making the whole deployer a single Golang module to make our life easier in future. We don't need moule versioning at this fine granularity. vHive can be a good example: it's a single module despite the folder structure. I suggesting having 1 module for vHive and 1 for deployer. No need for other modules, too complicated.
- remove binaries from the commit history (prune it! not just remove in a new commit)
- remove the YAML files duplication in golang files (I see 2 cases).
4c83dbc
to
9b9204b
Compare
unit test with github workflows change template to yaml Signed-off-by: Jason Chua <[email protected]>
9b9204b
to
7bb8cd1
Compare
Summary
Deploying openyurt on top of initial configs of k8s and knative.
To run, go build and ./openyurt_deployer deploy-yurt.
Implementation Notes ⚒️
External Dependencies 🍀
Breaking API Changes⚠️
Simply specify none (N/A) if not applicable.