Fix seg fault for catch(...) #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #718 +/- ##
==========================================
+ Coverage 94.54% 94.60% +0.05%
==========================================
Files 49 49
Lines 7189 7189
==========================================
+ Hits 6797 6801 +4
+ Misses 392 388 -4
|
vgvassilev
reviewed
Jan 18, 2024
lib/Differentiator/StmtClone.cpp
Outdated
Comment on lines
429
to
431
| DEFINE_CLONE_STMT(CXXCatchStmt, (Node->getCatchLoc(), | ||
| static_cast<VarDecl*>( | ||
| CloneDeclOrNull(Node->getExceptionDecl())), | ||
| Clone(Node->getHandlerBlock()))) |
There was a problem hiding this comment.
Suggested change
| DEFINE_CLONE_STMT(CXXCatchStmt, (Node->getCatchLoc(), | |
| static_cast<VarDecl*>( | |
| CloneDeclOrNull(Node->getExceptionDecl())), | |
| Clone(Node->getHandlerBlock()))) | |
| DEFINE_CLONE_STMT(CXXCatchStmt, (Node->getCatchLoc(), CloneDeclOrNull(Node->getExceptionDecl()), Clone(Node->getHandlerBlock()))) |
There was a problem hiding this comment.
removed the statiic_cast and ran clang-format again 👍🏼
There was a problem hiding this comment.
Either way the formatting looks ugly... let's move forward.
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #86