Remove the unused last know good release files. #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #699 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 49 49
Lines 7183 7183
=======================================
Hits 6791 6791
Misses 392 392 |
alexander-penev
approved these changes
Jan 4, 2024
vgvassilev
force-pushed
the
remove-last-known-good
branch
2 times, most recently
from
486cc36 to
f365ca7
Compare
In some cases we pass paths in quotes in CMAKE_CXX_FLAGS and that seems to confuse the ExternalProject_Add logic of our benchmarks.
vgvassilev
force-pushed
the
remove-last-known-good
branch
2 times, most recently
from
622154b to
728e984
Compare
vgvassilev
force-pushed
the
remove-last-known-good
branch
from
728e984 to
9f08e5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.