Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reroute pushforwards to the generic ::Derive method. #1193

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

vgvassilev
Copy link
Owner

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

lib/Differentiator/BaseForwardModeVisitor.cpp Show resolved Hide resolved
lib/Differentiator/BaseForwardModeVisitor.cpp Show resolved Hide resolved
"of real type.",
{(isField ? "member" : "parameter"), diffVarInfo.source});

DiffInputVarInfo diffVarInfo = DVI.back();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: no header providing "clad::DiffInputVarInfo" is directly included [misc-include-cleaner]

    DiffInputVarInfo diffVarInfo = DVI.back();
    ^

lib/Differentiator/BaseForwardModeVisitor.cpp Show resolved Hide resolved
lib/Differentiator/BaseForwardModeVisitor.cpp Outdated Show resolved Hide resolved
lib/Differentiator/BaseForwardModeVisitor.cpp Show resolved Hide resolved
lib/Differentiator/BaseForwardModeVisitor.cpp Show resolved Hide resolved
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.84%. Comparing base (c893c31) to head (aa5cbdf).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1193      +/-   ##
==========================================
- Coverage   94.86%   94.84%   -0.03%     
==========================================
  Files          51       51              
  Lines        8977     8936      -41     
==========================================
- Hits         8516     8475      -41     
  Misses        461      461              
Files with missing lines Coverage Δ
...clude/clad/Differentiator/BaseForwardModeVisitor.h 40.00% <100.00%> (+15.00%) ⬆️
lib/Differentiator/BaseForwardModeVisitor.cpp 98.69% <100.00%> (-0.05%) ⬇️
lib/Differentiator/DerivativeBuilder.cpp 100.00% <100.00%> (ø)
Files with missing lines Coverage Δ
...clude/clad/Differentiator/BaseForwardModeVisitor.h 40.00% <100.00%> (+15.00%) ⬆️
lib/Differentiator/BaseForwardModeVisitor.cpp 98.69% <100.00%> (-0.05%) ⬇️
lib/Differentiator/DerivativeBuilder.cpp 100.00% <100.00%> (ø)

@vgvassilev vgvassilev merged commit 76efb01 into master Dec 27, 2024
92 checks passed
@vgvassilev vgvassilev deleted the derive-8 branch December 27, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant