Skip to content

Commit

Permalink
Merge branch 'force-cxx-standard' into fix-include-references
Browse files Browse the repository at this point in the history
  • Loading branch information
adamnovak committed Oct 19, 2023
2 parents ab40ecd + 53af198 commit dfc3453
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ ifeq ($(shell uname -s),Darwin)
LD_UTIL_RPATH_FLAGS=""

# Homebrew installs a Protobuf that uses an Abseil that is built with C++17, so we need to build with at least C++17
CXX_STANDARD=17
CXX_STANDARD?=17

# We may need libraries from Macports
ifeq ($(shell if [ -d /opt/local/lib ];then echo 1;else echo 0;fi), 1)
Expand Down Expand Up @@ -221,7 +221,7 @@ else
$(info Compiler $(CXX) is assumed to be GCC)

# Linux can have some old compilers so we want to work back to C++14
CXX_STANDARD=14
CXX_STANDARD?=14

# Set an rpath for vg and dependency utils to find installed libraries
LD_UTIL_RPATH_FLAGS="-Wl,-rpath,$(CWD)/$(LIB_DIR)"
Expand Down Expand Up @@ -506,7 +506,10 @@ deps: $(DEPS)

test: $(BIN_DIR)/$(EXE) $(LIB_DIR)/libvg.a test/build_graph $(BIN_DIR)/shuf $(BIN_DIR)/vcf2tsv $(FASTAHACK_DIR)/fastahack $(BIN_DIR)/rapper
. ./source_me.sh && cd test && prove -v t
. ./source_me.sh && doc/test-docs.sh
# Hide the compiler configuration from the doc tests, so that the ones that
# build code can't pick up libraries out of the bg build itself. Definitely
# don't source source_me.sh!
CFLAGS= CXXFLAGS= CPPFLAGS= LDFLAGS= INCLUDE_FLAGS= LIBRARY_PATH= LD_LIBRARY_PATH= DYLD_LIBRARY_PATH= DYLD_FALLBACK_LIBRARY_PATH= LD_INCLUDE_PATH= CC= CXX= CXX_STANDARD= doc/test-docs.sh

# Somebody has been polluting the test directory with temporary files that are not deleted after the tests.
# To make git status more useful, we delete everything that looks like a temporary file.
Expand Down

1 comment on commit dfc3453

@adamnovak
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vg CI tests complete for branch fix-include-references. View the full report here.

16 tests passed, 0 tests failed and 0 tests skipped in 17510 seconds

Please sign in to comment.