Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crate Shelves #37151

Open
wants to merge 3 commits into
base: Bleeding-Edge
Choose a base branch
from
Open

Conversation

west3436
Copy link
Collaborator

@west3436 west3436 commented Sep 20, 2024

What this does

Ports Crate Shelves from shiptest-ss13/Shiptest#2374. Using modified sprites with original sprite credit to @Imaginos16.

image

demo

Shelves can be crafted with 3 metal sheets and are assembled and deconstructed the same way racks are. Three crates can be stacked on a shelf and cannot be opened until they are pulled off the shelf. Deconstructing an assembled shelf will drop the crates to the ground with a 5% chance of breaking one of the crates open. An admin-only extended version can stack up to 12 crates high for a very silly visual effect.

Why it's good

Gives QMs and Cargo Techs more power to organize their junk.

How it was tested

  • Crafting shelves.
  • Assembling and disassembling.
  • Dragging crates on and off.
  • Deconstructing the shelf with crates on it.

Changelog

🆑

  • rscadd: Added Crate Shelves which can be used to stack multiple crates in a single tile.

@west3436 west3436 added Content Adds something. Neat! Port Stolen/Ported from another codebase. labels Sep 20, 2024
@GenericDM
Copy link

Hello! Thank you for porting crate shelves, it's always a great feeling to see that someone thought my code was worth bringing somewhere else. Just so you know, the sprites were actually made by PositiveEntropy aka @Imaginos16
Also, if you haven't already, I'd suggest taking a look at the commit history of the file over on shiptest so that you can make sure you have the patches I made to fix some bugs.
Hope you enjoy the shelves!

@west3436
Copy link
Collaborator Author

Hello! Thank you for porting crate shelves, it's always a great feeling to see that someone thought my code was worth bringing somewhere else. Just so you know, the sprites were actually made by PositiveEntropy aka @Imaginos16 Also, if you haven't already, I'd suggest taking a look at the commit history of the file over on shiptest so that you can make sure you have the patches I made to fix some bugs. Hope you enjoy the shelves!

Thanks - credit updated!

@falcon2346
Copy link
Contributor

I feel like this doesn't have a high enough chance for horrific industrial accidents. I'd love to see a chance of it falling over and crushing some poor cargo tech if it's kicked

@ErrorsWindows
Copy link
Contributor

^ give the ability to unscrew (not unwrench) some parts and have it squish somebody like a vending machine

@SonixApache
Copy link
Contributor

map one into each cargo warehouse to replace that fucking useless rack with
wonder how hard it would be to add mapped variants with pre-inserted crates... probably not hard.

@@ -340,6 +340,7 @@ var/list/datum/stack_recipe/metal_recipes = list (
), 2),
new/datum/stack_recipe("table parts", /obj/item/weapon/table_parts, 2 ),
new/datum/stack_recipe("rack parts", /obj/item/weapon/rack_parts, ),
new/datum/stack_recipe("crate shelf parts", /obj/item/weapon/rack_parts/shelf, 3 ),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the sprite, clearly, this rack needs to cost 4 rods in addition to the 3 metal sheet requirement.........................

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Adds something. Neat! Port Stolen/Ported from another codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants