Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows credits to be claimed from recycling furnaces (plus access locking them) #37130

Open
wants to merge 11 commits into
base: Bleeding-Edge
Choose a base branch
from

Conversation

SECBATON-GRIFFON
Copy link
Contributor

@SECBATON-GRIFFON SECBATON-GRIFFON commented Sep 17, 2024

[content]

What this does

enables this process
also gives wood, plastic and cardboard values for this, at half the value of metal.
adds an option on smelting consoles to lock them to an ID's access, or unlock all access if there's already some. this only applies to claiming credits.

Why it's good

lets greytide make a tiny bit of extra cash on the side (not much though, as something with 50 sheets of metal worth of mats just gives 10 bucks back, with everything else new only giving back 5 for this amount)
allows the odd virtuous miner to let vox or space hobos or whatever claim them too

How it was tested

toolboxes in it, then adding sheet stacks as an exception to this credit counting to stop infinite money shenanigans.
inserting a janitor access ID, locking it with it, then inserting a blank id, then ejecting it, then unlocking it again with the janitor ID

Changelog

🆑

  • rscadd: Recycling furnaces can now have credits claimed from them for recycling, albeit meager amounts in the majority of cases. Material sheets and items created from stack recipes do not return any money this way.
  • rscadd: Smelter consoles can now be ID locked or unlocked to prevent claiming of credits. Recycling ones start unlocked by default, mining ones default to mining access. Emagging also removes all access locks.

@D3athrow-Issues D3athrow-Issues added the Content Adds something. Neat! label Sep 17, 2024
@wotisjanitor
Copy link
Contributor

wotisjanitor commented Sep 17, 2024

this should require a janitor ID, or else janitors will see all of their labors go to some greyshit

@RealestEstate
Copy link
Contributor

Seconding the janitor ID proposal

@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as draft September 18, 2024 16:34
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review September 18, 2024 16:40
@SECBATON-GRIFFON
Copy link
Contributor Author

this should require a janitor ID, or else janitors will see all of their labors go to some greyshit

added a way for janitors to lock it to themselves now

@SECBATON-GRIFFON SECBATON-GRIFFON changed the title Allows credits to be claimed from recycling furnaces Allows credits to be claimed from recycling furnaces (plus access locking them) Sep 18, 2024
@wotisjanitor
Copy link
Contributor

and if people dont like that i guess it could be hackable or something

@SECBATON-GRIFFON
Copy link
Contributor Author

and if people dont like that i guess it could be hackable or something

i was debating making emags override it yea

@DeityLink
Copy link
Collaborator

DeityLink commented Sep 20, 2024

I'm sure there's a few cases where you can just loop a crafting recipe to perpetually recycle it generate cash from nothing. Not saying that economics matter but that's pretty dumb.

If disposals let you actually get rid of trash by shipping it out, and you didn't get both the materials AND the cash back, that'd make more sense to me.

@SECBATON-GRIFFON
Copy link
Contributor Author

SECBATON-GRIFFON commented Sep 20, 2024

I'm sure there's a few cases where you can just loop a crafting recipe to perpetually recycle it generate cash from nothing. Not saying that economics matter but that's pretty dumb.

If disposals let you actually get rid of trash by shipping it out, and you didn't get both the materials AND the cash back, that'd make more sense to me.

good stuff to consider, made it so that even stack products of recycled sheets can no longer be claimed again for cash at all

@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as draft September 20, 2024 23:35
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review September 22, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Adds something. Neat!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants