Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables Contract of Apprenticeship during Civil War of Casters #36697

Conversation

boy2mantwicethefam
Copy link
Contributor

@boy2mantwicethefam boy2mantwicethefam commented Jun 16, 2024

Apprentices are pretty broken on the code side of things when it comes to being handled by the CWC faction code.

On top of that when there's already 4 wizards and then someone sends another 5-6 wizards to cause mayhem it leads to the sort of gunk that got Summon Guns banned from anything that isn't a roundstart wizard. Why is the Wizards Federation sending apprentices into the civil war now? Let them have their own fight! Every apprentice caught in the bloodshed is an apprentice that won't become a proper wizard. Plus it leads to a lot of friendly fire because the apprentices don't actually share the CWC faction so they can't tell who's an ally. I've seen pitbulls and other creatures summoned by mages attack their own apprentices because of this.

Does not affect midround wizards.

🆑

  • rscdel: The Contract of Apprenticeship can no longer be purchased by Civil War wizards.

@Eneocho Eneocho added Balance Potentially going to upset people as it changes balance of the game. Feature Loss Oh no, where'd this feature go? labels Jun 16, 2024
@Eneocho
Copy link
Collaborator

Eneocho commented Jun 16, 2024

I so fucking hate that kurf got rid of the funny tags, this desperately needed an I DED tag.

@boy2mantwicethefam
Copy link
Contributor Author

I'm not doing this out of salt, I just think it gets really messed up and there's a lot of accidental ban-baiting in the process. Imagine if the apprentice of a wizard fireballed a member of the civil war faction that the apprentice's master was part of, the apprentice has no way of knowing it because the apprentice is not technically part of the civil war, but it's probably grounds for a punishment from an admin even though they have no way of telling who's part of what. I made a PR to try to fix it (#36698) but I'm not sure if it actually works because multiple accounts on a self-hosted server do not work on my machine.

@Eneocho
Copy link
Collaborator

Eneocho commented Jun 16, 2024

fair enough
still, I do miss the funny tags like "i ded" or "cannot reproduce"

@jwhitak
Copy link
Collaborator

jwhitak commented Jun 25, 2024

We'll try the other solution first, where it attempts to join them to the correct factions.

@west3436
Copy link
Collaborator

Poor reception.

@west3436 west3436 closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Potentially going to upset people as it changes balance of the game. Feature Loss Oh no, where'd this feature go?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants