Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding outlook mail messages update functionality, which was not there #906

Closed
wants to merge 8 commits into from

Conversation

optimygmbh
Copy link
Contributor

This pull request allows to update a message in outlook based on this documentation:
https://learn.microsoft.com/en-us/graph/api/message-update?view=graph-rest-1.0&tabs=http

@vgrem
Copy link
Owner

vgrem commented Oct 23, 2024

Greetings @optimygmbh,

thank you for your contribution!

Regarding the update method, it seems you're referring to the existing update functionality. Below is an example demonstrating how the subject and body properties can be updated:

message.subject = "Updated subject"
message.body = "Updated body text"
message.update().execute_query()

In this approach, the message properties are exposed in a discoverable and autocompletable way, making it easier for developers to interact with.

On the other hand, using the method signature update(payload) seems less beneficial for the following reasons:

  • It reduces the discoverability of the properties.

  • It increases complexity when setting complex property values.

Best regards,
vgrem

@optimygmbh
Copy link
Contributor Author

Hi @vgrem
Makes a lot of sense, did not realize that it can be updated like that. Thanks for the clarification.
Best regards,
Tim

@optimygmbh optimygmbh closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants