Fix nondeterminism in DC serialization due to uninitialized padding.

vezel-dev · Jul 14, 2024 · fdedbd0 · fdedbd0
1 parent 4e858ef
commit fdedbd0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/formats/Data/Serialization/Items/DataCenterRawAttribute.cs b/src/formats/Data/Serialization/Items/DataCenterRawAttribute.cs
@@ -43,7 +43,7 @@ public static void Write(ref SpanWriter writer, DataCenterArchitecture architect
         writer.WriteInt32(item.Value);
 
         if (architecture == DataCenterArchitecture.X64)
-            writer.Advance(sizeof(uint));
+            writer.WriteUInt32(0); // Write a deterministic padding value.
     }
 
     public readonly bool Equals(DataCenterRawAttribute other)

diff --git a/src/formats/Data/Serialization/Items/DataCenterRawNode.cs b/src/formats/Data/Serialization/Items/DataCenterRawNode.cs
@@ -62,12 +62,12 @@ public static void Write(ref SpanWriter writer, DataCenterArchitecture architect
         DataCenterRawAddress.Write(ref writer, architecture, item.AttributeAddress);
 
         if (architecture == DataCenterArchitecture.X64)
-            writer.Advance(sizeof(uint));
+            writer.WriteUInt32(0); // Write a deterministic padding value.
 
         DataCenterRawAddress.Write(ref writer, architecture, item.ChildAddress);
 
         if (architecture == DataCenterArchitecture.X64)
-            writer.Advance(sizeof(uint));
+            writer.WriteUInt32(0); // Write a deterministic padding value.
     }
 
     public readonly bool Equals(DataCenterRawNode other)