-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(upgrades): set correct cluster_template_id #349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that fundamentally, we've relied historically on the code of Magnum
doing some form of 'inheritence' of the labels across clusters, however, the
reality is that it just copies everything over everywhere.
In order to make sure follow it, we stop checking parents (aka, check node
group if not found check cluster if not found check cluster template) and
instead rely on the label value directly configured. If the user used
merge labels then their values will be copied in, if they haven't, it will
copy their values in directly.
This fixes upgrades as well by making sure we set the correct cluster
template ID and copy all the labels, the main reason we had this issue
was because Magnum relied on the driver to copy the labels which we did
but we did not update the cluster template. So, cleaned that up and
added unit tests for coverage too.
Closes #317
Closes #325
Closes: #339