andreer/dynamic summary #1487
Merged
andreer/dynamic summary #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dynamic summary showing the "most relevant" section of the text (when there are literal matches). This is more like the typical "classic" SRP experience. We still need to actually turn the
sepandhitags into actual markup, currently it just looks like this:<sep />Reused/ recycled DisposedDischarged45.6% <hi>OF</hi> PRODUCED <hi>WATER</hi> IS REUSED OR RECYCLED 43.7% IS DISPOSED <hi>OF</hi> 10.7% IS DISCHARGED OFFSHORE AFTER TREATMENT92.4% <hi>OF</hi> <hi>SOURCE</hi> <hi>WATER</hi> IS <hi>NON</hi>-<hi>FRESH</hi> <hi>WATER</hi>, MUNICIPAL WASTE <hi>WATER</hi> AND REUSED OR RECYCLED PRODUCED <hi>WATER</hi> 7.6% IS <hi>FRESH</hi> <hi>WATER</hi>