Theodorkl/LSP integration #3347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodorklauritzen
commented
Aug 29, 2024
theodorklauritzen
commented
- Add closing html tag to all opened html tags
- Change some function signatures to make the documentation more uniform and easier to parse.
theodorklauritzen
changed the title
esolitos
reviewed
Aug 29, 2024
There was a problem hiding this comment.
ℹ️ The html tags <p> and <li> (among many others) don't need to be closed in HTML to be valid, this is only required for XHTML/XML. 😉
Ref 👉🏼 Tag omission in text/html
Beside that, nice initiative! 👍🏼
| @@ -847,7 +847,7 @@ <h3 id="attribute-match-features-normalized">Attribute match features - normaliz | |||
| </p><p> | |||
| <code>max( 1-age(name)/maxAge , 0 )</code> | |||
| </p><p> | |||
| Scales linearly with age, see <a href="#freshness">freshness plot</a>. | |||
| Scales linearly with age, see <a href="#freshness">freshness plot</a>.</p> | |||
There was a problem hiding this comment.
This should be closed above, as <p> taggas cannot be nested.
The P element represents a paragraph. It cannot contain block-level elements (including P itself).
Source: https://www.w3.org/TR/html401/struct/text.html#h-9.3.1
|
Thank I'll look into that! |
kkraune
approved these changes
Aug 29, 2024
Comment on lines
+1011
to
+1013
| <pre> | ||
| http://mysite.mydomain.com:8080/path/shop?d=hab&id=1804905709&cat=100#frag1 | ||
| </pre> |
There was a problem hiding this comment.
As the pre elements preserve whitespace, they look better without this indentation
Suggested change
| <pre> | |
| http://mysite.mydomain.com:8080/path/shop?d=hab&id=1804905709&cat=100#frag1 | |
| </pre> | |
| <pre> | |
| http://mysite.mydomain.com:8080/path/shop?d=hab&id=1804905709&cat=100#frag1 | |
| </pre> |
|
I have started over in a new branch here #3348, and will close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.