[FLINK-35575] Disable PERF_CONTEXT by default in compilation #76
Conversation
mayuehappy
force-pushed
the
FLINK-35575
branch
2 times, most recently
from
2d8be0f
to
6401e77
Compare
Makefile
Outdated
| @@ -429,6 +429,12 @@ ifndef DISABLE_JEMALLOC | |||
| PLATFORM_CCFLAGS += $(JEMALLOC_INCLUDE) | |||
| endif | |||
|
|
|||
| DISABLE_PERF_CONTEXT ?= 0 | |||
There was a problem hiding this comment.
Shouldn't this be 1? by default?
There was a problem hiding this comment.
@rkhachatryan
I initially set it to 1, but since there are some UTs depending on perf_context, so it may cause CI to fail.
So the way I used is to set the default value to 0 in the Makefile and then set it to 1 in the build script of frocksdb , it's that ok ?
There was a problem hiding this comment.
Thanks for clarifying, I'd be fine with that, but I don't see this change in the PR:
and then set it to 1 in the build script of frocksdb
Or am I missing something?
There was a problem hiding this comment.
@rkhachatryan I added DISABLE_PERF_CONTEXT=1 in the compilation script for Mac (FROCKSDB_VERSION=1.0 PORTABLE=1 ROCKSDB-DISMABLE_JEMALLOC=true DEBUG_LEVEL=0) to take effect in Mac products, and then added a commit to take effect in Docker compiled products (changes in docker-build-linux-centos.sh and docker-build-linux-alpine.sh)
There was a problem hiding this comment.
@rkhachatryan I added DISABLE_PERF_CONTEXT=1 in the compilation script for Mac (FROCKSDB_VERSION=1.0 PORTABLE=1 ROCKSDB-DISMABLE_JEMALLOC=true DEBUG_LEVEL=0)
Did you add it in this PR? I couldn't find this change.
added a commit to take effect in Docker compiled products (changes in docker-build-linux-centos.sh and docker-build-linux-alpine.sh)
Should we also update non-Docker scripts?
There was a problem hiding this comment.
@Zakelly I would like to ask,if I want to add DISABLE_PERF_CONTEXT=1 to the compilation script of all frocksdb environments. What do you think about this, or do you have any better suggestions?
There was a problem hiding this comment.
@Zakelly I would like to ask,if I want to add DISABLE_PERF_CONTEXT=1 to the compilation script of all frocksdb environments. What do you think about this, or do you have any better suggestions?
@mayuehappy I'd be OK with this.
FROCKSDB-RELEASE.md
Outdated
| @@ -195,7 +195,7 @@ To start the crossbuild within a Mac OSX environment: | |||
| cp <path-to-ppc64le-musl-lib-so>/librocksdbjni-linux-ppc64le-musl.so java/target/librocksdbjni-linux-ppc64le-musl.so | |||
| cp <path-to-arm-lib-so>/librocksdbjni-linux-aarch64.so java/target/librocksdbjni-linux-aarch64.so | |||
| cp <path-to-arm-musl-lib-so>/librocksdbjni-linux-aarch64-musl.so java/target/librocksdbjni-linux-aarch64-musl.so | |||
| FROCKSDB_VERSION=1.0 PORTABLE=1 ROCKSDB_DISABLE_JEMALLOC=true DEBUG_LEVEL=0 make frocksdbjavastaticreleasedocker | |||
| FROCKSDB_VERSION=1.0 PORTABLE=1 ROCKSDB_DISABLE_JEMALLOC=true DEBUG_LEVEL=0 DISABLE_PERF_CONTEXT=1 make frocksdbjavastaticreleasedocker | |||
There was a problem hiding this comment.
@rkhachatryan I think changing this place will enable DISABLE_PERF_CONTEXT when compiling on Mac?
There was a problem hiding this comment.
Yes, but only for Linux I believe. It would be nice to update for OSX too, but not mandatory IMObecause OSX isn't used in production and in benchmarks.
mayuehappy
force-pushed
the
FLINK-35575
branch
from
f646cba
to
898bcc3
Compare
|
@rkhachatryan @Zakelly |
|
Thanks for the update, LGTM+1 |
No description provided.