Upgrade operator-sdk to 1.38.0 #1040
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now I am still fixing the option "prometheus.expose=EnableWithAuthProxy", I cannot provide a custom tlsSecret to the manager. There aren't any logs from controller-runtime. After that issue is fixed, I will test rbac role authentication and then mark this PR to be ready. |
cchen-vertica
force-pushed
the
cchen/upgrade-sdk
branch
from
a4288d2 to
8d7028c
Compare
|
You did not need any library upgrades? |
cchen-vertica
force-pushed
the
cchen/upgrade-sdk
branch
from
858c096 to
85ee265
Compare
cchen-vertica
requested review from
roypaulin,
fenic-fawkes,
HaoYang0000,
qindotguan and
LiboYu2
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgraded operator-sdk from 1.28.0 to 1.38.0. Refer to this page for the operator side changes: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.38.0/. Refer to this page for the controller-runtime API changes: https://github.com/kubernetes-sigs/controller-runtime/tree/v0.18.4.