add new object metric and fix e2e test #1035
Conversation
LiboYu2
requested review from
roypaulin,
cchen-vertica,
fenic-fawkes,
HaoYang0000 and
qindotguan
as code owners
| resource: namespace | ||
| service: | ||
| resource: service | ||
| seriesQuery: vertica_sessions_running_counter{namespace!="", service!= "", type="active", initiator="user"} |
There was a problem hiding this comment.
| seriesQuery: vertica_sessions_running_counter{namespace!="", service!= "", type="active", initiator="user"} | |
| seriesQuery: vertica_sessions_running_counter{namespace!="", service!= "", type="active"} |
There was a problem hiding this comment.
There are a lot of sessions which are initiated by the system. Those numbers are pretty large. We have to exclude those from calculating this metric.
| @@ -33,7 +33,18 @@ rules: | |||
| pod: | |||
| resource: pod | |||
| metricsQuery: 'avg_over_time(vertica_process_memory_usage_percent[60m])' | |||
| # # Number of active sessions. Type: guage | |||
| # Total number of active sessions. Type: guage | |||
| - metricsQuery: sum(vertica_sessions_running_counter{namespace!="", service!= "", type="active", initiator="user"}) by (namespace, service) | |||
There was a problem hiding this comment.
| - metricsQuery: sum(vertica_sessions_running_counter{namespace!="", service!= "", type="active", initiator="user"}) by (namespace, service) | |
| - metricsQuery: sum(vertica_sessions_running_counter{type="active"}) by (namespace, service) |
There was a problem hiding this comment.
same comment as above.
| @@ -15,7 +15,8 @@ apiVersion: kuttl.dev/v1beta1 | |||
| kind: TestStep | |||
| commands: | |||
| - script: | | |||
| NAMESPACE=$(kubectl get pod v-prometheus-pri1-0 -o=jsonpath='{.metadata.namespace}') | |||
| echo "sleep 120 seconds before starting to verify metrics" | |||
There was a problem hiding this comment.
We don't need this sleep.
There was a problem hiding this comment.
It took me a lot of time to debug the failure. The metric is not available right away after the adapter is installed. We have to wait some time. We need it.
|
Please share the verticaautoscaler you used to test this. Put it in the prometheus folder. |
|
@LiboYu2 You did not address my comments. |
I added it to config/samples/v1beta1_verticaautoscaler_custom_metrics.yaml |
|
@LiboYu2 Please wait until all the tests pass before merging, even if the PR is approved. |
1 add vertica_sessions_active_count object metric
2 fix e2e test prometheus-sanity