doc how to avoid undefined symbol of PCRE issue without uninstall existing PCRE packages #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a/packages/odbc-loader/lib
…ut uninstall existing PCRE packages
williammatherjones
requested changes
Aug 11, 2023
| @@ -4,9 +4,9 @@ SDK_HOME ?= /opt/vertica/sdk | |||
| SHELL = /bin/bash | |||
| VSQL ?= /opt/vertica/bin/vsql | |||
| LOADER_DEBUG = 0 | |||
| TARGET ?= /opt/vertica/packages/odbc-loader/lib | |||
| TARGET ?= ./lib | |||
There was a problem hiding this comment.
Changing the target to ./lib causes the CI tests to fail. Why is this change needed? Can we revert this to /opt/vertica/packages/odbc-loader/lib?
| @@ -1,4 +1,5 @@ | |||
| CREATE OR REPLACE LIBRARY ODBCLoaderLib AS '/opt/vertica/packages/odbc-loader/lib/ODBCLoader.so'; | |||
| \set libfile '\''`pwd`'/lib/ODBCLoader.so\''; | |||
There was a problem hiding this comment.
This change would need to be reverted if we revert the lib location change in Makefile.
|
@williammatherjones why not just permit dbadmin user in docker writing project directory? Customers not always put project under /opt/vertica/packages/, that will confuse them where the so is if we hard code as /opt/vertica/packages/odbc-loader/lib/ODBCLoader.so. |
|
I fixed the CI test failure. Now this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An environment has high version PCRE, uninstall them will fail the operation system.
This PR give a way to let multiple version of PCRE coexist.
#10 #11 #12